472239 - [FIX]pdf (.pdf) files fail to load since 20090104 nightly

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[u88484]

pdf files fail to load using 20090105 nightly on Vista and XP, not sure about linux or Mac.  No errors in the console.

Test link provided in URL input field

Comment 1

[u88484]

Regression range:

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b7c83a7b2b24&tochange=9f497b1505d2

Comment 2

[TimoT]

Seems to be caused by bug 466384, backed it out locally and pdfs load again.

Comment 3

[Bill Gianopoulos [:WG9s]]

Changing procuct and component based on comment #2

Comment 4

[Bill Gianopoulos [:WG9s]]

As a work-around, you can load PDF files by disabling the Adobe Reader plug-in.  This bug only impacts PDF access via the Adobe plug-in.

Comment 5

[Bill Gianopoulos [:WG9s]]

Attachment: workaround

I consider this more of a kludge than a proper fix.  However, it does restore plug-in functionality without reverting the fix from bug 466384.

I do not intend to request review on this patch, nor do I intend to take this bug.

Comment 6

[Gerd]

Hello,

this bug seems to affect also the Foxit Reader plugin (www.foxitsoftware.com). Trying to display a PDF using this plugin results in an empty page (nothing is displayed).

Kind regards.

Comment 7

[Larry Snow]

Yes Gerd, this does affect the newest release of Foxit 3.0 (build 1301) on XP Pro SP3.  I cannot open any pdf files within the browser.  I just get an empty page.

Comment 8

[RFLazaro]

That's interesting, it's working fine for me
- Firefox 3.2a1pre ID:20090106034601
- Foxit 3.0 (build 1301)
- WinXP SP2 (note SP2 not SP3)

Comment 9

[RFLazaro]

I take it back, I was not opening files IN the browser

Sorry for the spam

Comment 11

[Peter van der Woude [:Peter6]]

same problem when an swf isn't embedded in a page

Comment 12

[Boris Zbarsky [:bzbarsky]]

Attachment: This should fix it

Comment 13

[Bill Gianopoulos [:WG9s]]

(In reply to comment #12)
> Created an attachment (id=355786) [details]
> This should fix it

Well, I can verify that it builds under both Linux and Windows and fixes all the known regressions from bug 466384.

Comment 14

[Boris Zbarsky [:bzbarsky]]

Great.  I'd built it on Mac and tested the quicktime thing there.  Plus it's clearly the right thing to be doing.  ;)

Thank you for testing this!  One of these days we'll have some plug-in regression tests, I hope.

Comment 15

[Boris Zbarsky [:bzbarsky]]

Pushed http://hg.mozilla.org/mozilla-central/rev/96e5551239e6.

Comment 16

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090109 Minefield/3.2a1pre ID:20090109110546

verified fixed on windows

Comment 17

[Marcia Knous [:marcia]]

https://litmus.mozilla.org/show_test.cgi?id=7456

Comment 18

[Marcia Knous [:marcia]]

verified fixed using Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20090112 Minefield/3.2a1pre.