Closed Bug 472321 Opened 16 years ago Closed 16 years ago

Remove AbcParser asserts for conditions that trigger a verify error

Categories

(Tamarin Graveyard :: Virtual Machine, defect)

Product:
Tamarin Graveyard
Component:
Virtual Machine
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: edwsmith, Unassigned)

Details

Attachments

(1 file)

make assert abort(), and remove two bogus asserts
1018 bytes, patch
lhansen
: review+
Details | Diff | Splinter Review 
Two asserts in AbcParser aren't checking for bugs in the abc parser, they are firing on invalid ABC input, which is what verify errors are for.
Attachment #355591 - Flags: review?(jodyer)
Attachment #355591 - Attachment is patch: true
Attachment #355591 - Attachment mime type: application/octet-stream → text/plain
Attachment #355591 - Flags: review?(lhansen)
Attachment #355591 - Flags: review?(lhansen) → review+
pushed changeset:   1261:e50d6321286f
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Attachment #355591 - Flags: review?(jodyer)
Resolved fixed engineering / work item that has been pushed.  Setting status to verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: