Closed
Bug 472466
Opened 16 years ago
Closed 14 years ago
No small icons in edit event/task dialog available
Categories
(Calendar :: Dialogs, defect)
Calendar
Dialogs
Tracking
(Not tracked)
RESOLVED
FIXED
1.0b2
People
(Reporter: andreas.treumann, Assigned: Taraman)
References
Details
Attachments
(1 file, 2 obsolete files)
144.79 KB,
patch
|
Taraman
:
review+
|
Details | Diff | Splinter Review |
STEPS TO REPRODUCE: =================== - open the edit event/task dialog - open the customize toolbar dialog - check the 'Use Small Icons' control RESULT: ======= - the icon size isn't changed EXPECTED RESULT: ================ - a toolbar with small icons REPRODUCIBLE: ============= - always
Comment 1•16 years ago
|
||
For the toolbar icons in the dialog no small version is available (see calendar/base/themes/[w|p]instripe/dialogs/calendar-event-dialog-toolbar.png)
Updated•15 years ago
|
Component: General → Dialogs
Updated•15 years ago
|
QA Contact: general → dialogs
Assignee | ||
Comment 3•14 years ago
|
||
Can we disable the option in the customize dialog?
Comment 4•14 years ago
|
||
A better solution would be to provide small icons. Current event dialog toolbar is just a combination of the old Thunderbird toolbars: http://mxr.mozilla.org/comm-central/source/calendar/base/themes/pinstripe/dialogs/calendar-event-dialog-toolbar.png http://mxr.mozilla.org/mozilla1.8.0/source/mail/themes/pinstripe/mail/compose/compose-toolbar.png http://mxr.mozilla.org/mozilla1.8.0/source/mail/themes/pinstripe/mail/icons/mail-toolbar.png http://mxr.mozilla.org/comm-central/source/calendar/base/themes/winstripe/dialogs/calendar-event-dialog-toolbar.png http://mxr.mozilla.org/mozilla1.8.0/source/mail/themes/qute/mail/compose/compose-toolbar.png http://mxr.mozilla.org/mozilla1.8.0/source/mail/themes/qute/mail/icons/mail-toolbar.png We could copy the current toolbars again (but both large and small) version and update the css rules.
Assignee | ||
Comment 5•14 years ago
|
||
If the Small Icons are at hand, that is the better solution. Taking over then.
Assignee: nobody → Mozilla
Status: NEW → ASSIGNED
Assignee | ||
Comment 6•14 years ago
|
||
Built and tested ok on Windows with winstripe theme. Pinstripe unchecked.
Attachment #423867 -
Flags: ui-review?(clarkbw)
Attachment #423867 -
Flags: review?(ssitter)
Assignee | ||
Comment 7•14 years ago
|
||
forgot to include the images... ;-(
Attachment #423867 -
Attachment is obsolete: true
Attachment #423869 -
Flags: ui-review?(clarkbw)
Attachment #423869 -
Flags: review?(ssitter)
Attachment #423867 -
Flags: ui-review?(clarkbw)
Attachment #423867 -
Flags: review?(ssitter)
Updated•14 years ago
|
Attachment #423869 -
Flags: ui-review?(clarkbw)
Attachment #423869 -
Flags: review?(ssitter)
Attachment #423869 -
Flags: review+
Comment 8•14 years ago
|
||
Comment on attachment 423869 [details] [diff] [review] Patch V1.1 - include .png files >--- a/calendar/base/themes/pinstripe/dialogs/calendar-event-dialog.css >+++ b/calendar/base/themes/pinstripe/dialogs/calendar-event-dialog.css > >+toolbar[iconsize="small"] #button-save { >+ -moz-image-region: rect(0px 144px 24px 1620px); >+} >+toolbar[iconsize="small"] #button-save[disabled="true"], >+toolbar[iconsize="small"] #button-save[disabled="true"]:hover, >+toolbar[iconsize="small"] #button-save[disabled="true"]:hover:active { >+ -moz-image-region: rect(48px 144px 72px 120px); >+} I think 1620px should be 120px, otherwise the patch looks fine to me. r=ssitter. I don't think we need ui-review because we just add the small version of the existing icons.
Assignee | ||
Comment 9•14 years ago
|
||
>+ -moz-image-region: rect(0px 144px 24px 1620px);
>I think 1620px should be 120px, otherwise the patch looks fine to me.
Damn, I knew I would miss a typo in this. ;-)
And I found one more:
+toolbar[iconsize="small"] #button-spellcheck {
+ -moz-image-region: rect(0px 48px 216px 32px);
which should read 16 iso 216
Patch updated
Attachment #423869 -
Attachment is obsolete: true
Attachment #424963 -
Flags: review+
Assignee | ||
Comment 10•14 years ago
|
||
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/0a8ce305dbdc> -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.0
Updated•14 years ago
|
Target Milestone: 1.0 → 1.0b2
Comment 11•14 years ago
|
||
verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.9pre) Gecko/20100204 Calendar/1.0b2pre
Status: RESOLVED → VERIFIED
Comment 12•14 years ago
|
||
(In reply to comment #11) How? This fix is not available in comm-1.9.1 based builds like Sunbird 1.0b2pre.
Updated•14 years ago
|
Status: VERIFIED → RESOLVED
Closed: 14 years ago → 14 years ago
You need to log in
before you can comment on or make changes to this bug.
Description
•