473517 - Remove heap allocated nsSVGLength in nsSVGUtils::CoordToFloat

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Craig Topper]

nsSVGUtils::CoordToFloat uses a short lived heap allocated nsSVGLength to do a calculation. This can be replaced with a stack allocated nsSVGLength2 to get the same effect.

Comment 1

[Craig Topper]

Attachment: Patch

Comment 2

[Jonathan Watt [:jwatt]]

Can you remove the include too?

Also, any reason to not use:

  case eStyleUnit_Percent:
    nsSVGSVGElement* ctx = aContent->GetCtx();
    return ctx ? aCoord.GetPercentValue() * ctx->GetLength(nsSVGUtils::XY) : 0;

Comment 3

[Craig Topper]

I considered doing it, but the real length code also has a check for GetLength returning 0.0f and changes it to 1e-20. So I was trying to make this code simple by reuse existing stuff.

While typing this and re-reading the code I realized the 1e-20 was to prevent a divide by 0. Obviously there is no division in your proposed code. I'll go ahead and make the change.

Comment 4

[Craig Topper]

Attachment: Changes to jwatt's suggestion

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Pushed http://hg.mozilla.org/mozilla-central/rev/07c89c67e4b9