Closed
Bug 473739
Opened 16 years ago
Closed 16 years ago
Bad return value in nsDOMStorage::CacheStoragePermissions()
Categories
(Core :: DOM: Core & HTML, defect, P2)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
People
(Reporter: dcamp, Assigned: dcamp)
References
Details
(Keywords: fixed1.9.1)
Attachments
(1 file)
|
632 bytes,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
Taras' tool found a dumb mistake in the patch from bug 458091, returning an nsresult where we should be returning a bool.
Attachment #357126 -
Flags: superreview?(bzbarsky)
Attachment #357126 -
Flags: review?(bzbarsky)
Attachment #357126 -
Flags: approval1.9.1?
|
||
Updated•16 years ago
|
Attachment #357126 -
Flags: superreview?(bzbarsky)
Attachment #357126 -
Flags: superreview+
Attachment #357126 -
Flags: review?(bzbarsky)
Attachment #357126 -
Flags: review+
|
Assignee | |
Comment 1•16 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/9b5a61f187f1
Status: NEW → RESOLVED
Closed: 16 years ago
Flags: blocking1.9.1?
Resolution: --- → FIXED
|
||
Updated•16 years ago
|
Flags: blocking1.9.1? → blocking1.9.1+
Priority: -- → P2
|
||
Updated•15 years ago
|
Attachment #357126 -
Flags: approval1.9.1?
|
|
||
Comment 2•15 years ago
|
||
Comment on attachment 357126 [details] [diff] [review] fix This is a blocker, doesn't need approval. dcamp, can you land this on the branch when you get a chance?
|
||
Comment 3•15 years ago
|
||
jst, bz: can one of you guys land this for dcamp?
|
|
Assignee | |
Comment 4•15 years ago
|
||
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/ba76edffc635
Keywords: fixed1.9.1
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•