473992 - Create separate theme folders for hildon(maemo) and wince

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Fennec needs to support separate themes (skins) for building Maemo and Windows Mobile.

This patch separates the chrome/skin folder into two theme folders:
* create theme/hildon and theme/wince folders
* update makefiles
* moves firstrun files out of the chrome/content folder and into the theme folders
* defaults to the hildon theme (so desktop builds will also use it)
* added a new platform.css file for the low-level theme changes (pulled code from browser.css)

There are a lot of deletes/adds in the patch

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch 2 - used hg to move stuff around

this patch should be the same as the first patch, but I used hg rename to move all of the skin files into the themes/hildon folder. I still had to add them all again in the wince folder.

It might be a tad easier to review

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 357828 [details] [diff] [review]
patch 2 - used hg to move stuff around

r=me, but you should use |hg cp| rather than manually copying/hg adding the wince files.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch 3 - used | hg cp | to copy in the wince folder

final patch used for checkin

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

http://hg.mozilla.org/mobile-browser/rev/ac352ddf763b

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

verified fixed in 20091001 1.9.2 b4 on my n810 and via mxr.