474361 - remove and rename calendar-decorated panes

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Berend Cornelius]

With the integration of Bug 468420 -  Consolidation of the navigation bar the following decorated panes should be renamed (see also bug 468420 comment #15):
calendar/calendar-decorated-day-view
calendar/calendar-decorated-week-view
calendar-decorated-multiweek-view
calendar/calendar-decorated-month-view

The following bindings should be merged into the current calendar-multiday-view binding and calendar-month-view-binding:
-calendar-decorated-month-view-parent
-calendar-decorated-multiday-base-view

Comment 1

[Berend Cornelius]

Attachment: patch v. #1

first patch that I want to test before I will ask for review. Within this patch I have almost only moved code and renamed bindings and have only done other code changes where it was really necessary (despite from adapting some source code comments).

Comment 2

[Berend Cornelius]

Comment on attachment 357737 [details] [diff] [review]
patch v. #1

I could not detect any bad impact of the patch so I am asking for review.

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 357737 [details] [diff] [review]
patch v. #1

Looks good to me, r=philipp

Comment 4

[Berend Cornelius]

patches pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/848ca565d94e
http://hg.mozilla.org/comm-central/rev/9e051408695e
http://hg.mozilla.org/comm-central/rev/f491e73f7923

-> fixed!

Comment 5

[Berend Cornelius]

Attachment: patch v. #2

Reopening patch. There are two boxes with a lightgrey background in the week-view above the time-scale and the scrollbox. The background-color should be white of course.

Comment 6

[Berend Cornelius]

pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/2e75cd634b87

-> fixed

Comment 7

[Andreas Treumann]

Checked in lightning and sunbird build 20090128 -> VERIFIED.