Closed
Bug 474401
Opened 16 years ago
Closed 13 years ago
Firefox on Mac does not register itself as being capable of opening SVG files
Categories
(Core :: SVG, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jwatt, Assigned: jwatt)
References
Details
Attachments
(1 file)
1.35 KB,
patch
|
jaas
:
review+
|
Details | Diff | Splinter Review |
Firefox on Mac does not register itself as being capable of opening SVG files.
Assignee | ||
Comment 1•16 years ago
|
||
Being new to Mac I'm having trouble figuring out what needs to happen to fix this. Any pointers Josh?
Probably need to edit this file with an svg extension: http://mxr.mozilla.org/mozilla-central/source/browser/app/macbuild/Contents/Info.plist.in
Assignee | ||
Comment 3•16 years ago
|
||
Thanks!
Assignee | ||
Updated•15 years ago
|
Assignee: nobody → jwatt
Assignee | ||
Comment 4•13 years ago
|
||
Just had someone ask if this'll be fixed for FF4. Not sure if that's possible, but anyway the patch is trivial so here it is.
Attachment #507082 -
Flags: review?
Updated•13 years ago
|
Version: unspecified → Trunk
Assignee | ||
Updated•13 years ago
|
Attachment #507082 -
Flags: review? → review?(joshmoz)
Comment on attachment 507082 [details] [diff] [review] patch Seems like there are some unnecessary things in here. For example, I don't think the MIME entry is helpful in any way. Why not just add "svg" to the existing list of image formats we support, right after "<string>gif</string>"? That would be a one-line patch.
Attachment #507082 -
Flags: review?(joshmoz) → review-
Assignee | ||
Comment 7•13 years ago
|
||
Sometimes I really hate bugzilla. Back when I originally requested review and bugzilla silently dropped the email address I used intending to get review from you I'd spent hours researching this and knew exactly why I took this route. Months on I've now forgotten. *sigh* One thing I did do was take a look a what Safari and Chrome use though, and Safari does this. I guess I'm going to have to dig back into this again and follow all the "this mechanism is deprecated by this mechanism, which is deprecated by this, which is..." links I followed previously to figure out the rational though.
Assignee | ||
Comment 8•13 years ago
|
||
In fact it seems Chrome has changed to have exactly the same section as Safari now. They both have: <dict> <key>CFBundleTypeExtensions</key> <array> <string>svg</string> </array> <key>CFBundleTypeIconFile</key> <string>document.icns</string> <key>CFBundleTypeMIMETypes</key> <array> <string>image/svg+xml</string> </array> <key>CFBundleTypeName</key> <string>SVG document</string> <key>CFBundleTypeRole</key> <string>Viewer</string> <key>NSDocumentClass</key> <string>BrowserDocument</string> </dict>
Assignee | ||
Comment 9•13 years ago
|
||
If I recall correctly, the difference was that older versions of Chrome did not have the CFBundleTypeMIMETypes key.
Assignee | ||
Comment 10•13 years ago
|
||
(In reply to comment #6) > Why not just add "svg" to the existing list of image formats we support, right > after "<string>gif</string>"? That would be a one-line patch. And to answer that question, because SVG is primarily a document type, with an option to treat it in a restricted way as an image. It's not primarily an image.
Assignee | ||
Comment 11•13 years ago
|
||
Comment on attachment 507082 [details] [diff] [review] patch Re-requesting review, since I'm hoping the above is enough to persuade that this patch is correct and save me from trawling back through MDC docs.
Attachment #507082 -
Flags: review- → review?
Attachment #507082 -
Flags: review? → review+
Assignee | ||
Comment 12•13 years ago
|
||
Thanks! Pushed http://hg.mozilla.org/mozilla-central/rev/1993865501f5
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•