474638 - Snooze or dismiss of alarms doesn't work

Status: RESOLVED FIXED

(Calendar :: Alarms, defect)

Description

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090121 Calendar/1.0pre (BuildID: 20090121080753)

Steps to Reproduce:
1. Create a non-repeating event (due to Bug 474630) with alarm
2. Wait until the alarm fires and snooze or dismiss the alarm

Actual Results:
Pressing snooze or dismiss does nothing, the alarm dialog is still displayed. Pressing again trows a MODIFICATION_FAILED error.

Expected Results:
Alarm can be snoozed or dismissed.

Additional Information:
Tested with both storage and ics provider.

Comment 1

[Stefan Sitter [:ssitter]]

Regression range: Works in Sunbird 1.0pre (2009-01-19-02-40-56)
                  Fails in Sunbird 1.0pre (2009-01-19-03-24-18)

Checkins: https://hg.mozilla.org/comm-central/pushloghtml?startdate=2009-01-19+02:00&enddate=2009-01-19+04:00

Comment 2

[Stefan Sitter [:ssitter]]

We need to update http://mxr.mozilla.org/comm-central/source/calendar/base/src/calAlarmMonitor.js#41 because Bug 474276 changed the windows type.

Comment 3

[Stefan Sitter [:ssitter]]

Attachment: use correct windowtype

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 357993 [details] [diff] [review]
use correct windowtype

Good catch, thanks for the patch!

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/7fdf4014635a>

-> FIXED