Closed Bug 475268 Opened 15 years ago Closed 15 years ago

CSS for XML tree view changes background color but leaves text color as default

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: mihaicapota, Assigned: bzbarsky)

References

()

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; ro; rv:1.9.0.5) Gecko/2008121621 Ubuntu/8.04 (hardy) Firefox/3.0.5
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; ro; rv:1.9.0.5) Gecko/2008121621 Ubuntu/8.04 (hardy) Firefox/3.0.5

The default style for XML rendering changes the background color but leaves text color as default.
This is a problem when the default text color is not black, e.g. when using a light text on dark background theme.

Reproducible: Always

Steps to Reproduce:
1. Set the text color to white and the background color to black.
2. Open an XML file, e.g. http://www.w3schools.com/xml/cd_catalog.xml
Actual Results:  
The background of the page is set to white, while the element content text is left as default, also white, thus unreadable.

Expected Results:  
The page should be readable. The element content text color should be set to something dark to contrast with the background.
Indeed it is. I thought there was already a bug somewhere, but can't find it.

It is a bit similar to bug 437366...
According to the DomInspector, the background of the unstyled XML page is set to 'white' (*|*:root {} in viewsource.css) but no color is specified.
Component: General → Style System (CSS)
OS: Linux → All
Product: Firefox → Core
QA Contact: general → style-system
Hardware: x86 → All
Summary: XML rendering CSS changes background color but leaves text color as default → CSS for XML tree view changes background color but leaves text color as default
Attached patch Like soSplinter Review
Jonas, what do you think of also moving the -moz-fixed font-family decl?
Assignee: nobody → bzbarsky
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #358784 - Flags: superreview?(jonas)
Attachment #358784 - Flags: review?(jonas)
Attachment #358784 - Flags: superreview?(jonas)
Attachment #358784 - Flags: superreview+
Attachment #358784 - Flags: review?(jonas)
Attachment #358784 - Flags: review+
Comment on attachment 358784 [details] [diff] [review]
Like so

don't know enough about -moz-fixed to have an opinion on that.
moz-fixed just means the user's default monospace font.
Pushed http://hg.mozilla.org/mozilla-central/rev/a6bcf72d1d75
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Oh, I'm with you. Would make sense to move it, but I don't care much either way
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: