475271 - Synchronize id for View menu between Thunderbird and Firefox

Status: RESOLVED WONTFIX

(Thunderbird :: Mail Window Front End, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

The id for the View menu should be synchronized, Thunderbird's called "menu_View_Popup" while Firefox's called "menu_viewPopup". It's a pain for extension development when the difference between them is merely capitalization/underscores.

Thunderbird: http://mxr.mozilla.org/comm-central/source/mail/base/content/mailWindowOverlay.xul#944
Firefox: http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser-menubar.inc#212

Comment 1

[Wayne Mery (:wsmwk)]

What about SM?

Comment 2

[Philip Chee]

<http://mxr.mozilla.org/comm-central/search?string=menu_View_Popup&find=suite>

SeaMonkey uses "menu_View_Popup" in several (9) places. Except where we just use "viewPopup" for bits of the history UI that we ported from FireBadger.

<http://mxr.mozilla.org/comm-central/search?string=View_Popup&find=mail&findi=&filter=%5E%5B%5E%5C0%5D*%24&hitlimit=&tree=comm-central>
Thunderbird uses "menu_View_Popup" in five places and Shared MailNews code uses this in two places.

While synchronizing IDs is good in general I'm concerned (speaking as an extension author) about breaking existing Thunderbird and SeaMonkey extensions. Extensions that support Firefox as well as SeaMonkey and/or Thunderbird already use separate overlays or use the nested overlay mount point technique that I've been teaching Firefox extension authors that want to port their extensions to SeaMonkey.

Phil

Comment 3

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

This seems to be too much trouble for just spelling synchronization as it can break existing extensions.

-> WONTFIX