475750 - Generate warnings for out-of-order initialization where possible

Status: VERIFIED FIXED

(Tamarin Graveyard :: Virtual Machine, defect)

Description

[Lars T Hansen]

The order of member variables in the intialization list for few classes is
different than the order of their declaration.  Some compilers give warnings
for such code (which is buggy in sinister way), but some don't, by default.  We need to change our settings for the reference versions of gcc and msvc so that warnings are generated for this problem.

Comment 1

[Lars T Hansen]

-Wreorder in gcc

Comment 2

[Lars T Hansen]

Bizarrely this is turned off in configure.py: -Wno-reorder.  That's just wrong, these are real bugs waiting to happen.  Turning it on in Xcode results in warnings in about 10 files, it's not unreasonable to fix this.

Comment 3

[Lars T Hansen]

Attachment: Fix for Xcode and cross-platform build

Comment 4

[Lars T Hansen]

Attachment: Fix warnings introduced by turning on -Wreorder (Xcode)

Comment 5

[Lars T Hansen]

Comment on attachment 371210 [details] [diff] [review]
Fix for Xcode and cross-platform build

redux changeset:   1675:88d0e0730e41

Comment 6

[Lars T Hansen]

Comment on attachment 371229 [details] [diff] [review]
Fix warnings introduced by turning on -Wreorder (Xcode)

redux changeset:   1676:0bb02b1f0c8c

Comment 7

[Lars T Hansen]

Approx 10 minutes of searching leads to the conclusion that Visual Studio does not have a warning switch like -Wreorder.  I could have sworn that Visual C++ version 6 did, but that's a long time ago and my memory may be faulty.