Closed
Bug 475836
Opened 15 years ago
Closed 15 years ago
ImtBuilder::finish doesn't need to do anything when MIR is disabled at runtime
Categories
(Tamarin Graveyard :: Virtual Machine, defect)
Tamarin Graveyard
Virtual Machine
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: stejohns, Unassigned)
Details
Attachments
(1 file, 1 obsolete file)
465 bytes,
patch
|
edwsmith
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #359402 -
Flags: review?(edwsmith)
Updated•15 years ago
|
Attachment #359402 -
Flags: review?(edwsmith) → review-
Comment 1•15 years ago
|
||
Comment on attachment 359402 [details] [diff] [review] Patch Traits::resolveSignatures() does not call ImtBuilder::finish if !IsMIREnabled().
Reporter | ||
Comment 2•15 years ago
|
||
You're right. It should be an assert instead.
Reporter | ||
Comment 3•15 years ago
|
||
Attachment #359402 -
Attachment is obsolete: true
Attachment #359564 -
Flags: review?(edwsmith)
Comment 4•15 years ago
|
||
Comment on attachment 359564 [details] [diff] [review] Patch #2 -- change check to assertion looks fine, but how did you ever manage to hit that case?
Attachment #359564 -
Flags: review?(edwsmith) → review+
Reporter | ||
Comment 5•15 years ago
|
||
I think it's a holdover from when the caller didn't check... the test here was inserted (in a different branch) and I didn't check appropriately before offering this bit for merging. it's probably redundant but assertions are cheap...
Reporter | ||
Comment 6•15 years ago
|
||
changeset: 1368:3013f72b8503
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → INVALID
Reporter | ||
Updated•15 years ago
|
Resolution: INVALID → FIXED
Updated•15 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•