Closed Bug 475836 Opened 15 years ago Closed 15 years ago

ImtBuilder::finish doesn't need to do anything when MIR is disabled at runtime

Categories

(Tamarin Graveyard :: Virtual Machine, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: stejohns, Unassigned)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch (obsolete) — Splinter Review
      No description provided.
Attachment #359402 - Flags: review?(edwsmith)
Attachment #359402 - Flags: review?(edwsmith) → review-
Comment on attachment 359402 [details] [diff] [review]
Patch

Traits::resolveSignatures() does not call ImtBuilder::finish if !IsMIREnabled().
You're right. It should be an assert instead.
Attachment #359402 - Attachment is obsolete: true
Attachment #359564 - Flags: review?(edwsmith)
Comment on attachment 359564 [details] [diff] [review]
Patch #2 -- change check to assertion

looks fine, but how did you ever manage to hit that case?
Attachment #359564 - Flags: review?(edwsmith) → review+
I think it's a holdover from when the caller didn't check... the test here was inserted (in a different branch) and I didn't check appropriately before offering this bit for merging. it's probably redundant but assertions are cheap...
changeset:   1368:3013f72b8503
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → INVALID
Resolution: INVALID → FIXED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: