Closed Bug 475885 Opened 15 years ago Closed 15 years ago

Error compiling uninstaller - StrCpy expects 2-4 parameters, got 6. in CreateShortcutsLog

Categories

(Firefox :: Installer, defect, P1)

3.5 Branch
x86
Windows Vista
defect

Tracking

()

RESOLVED FIXED
Firefox 3.1b3

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

References

Details

(Keywords: fixed1.9.1)

Attachments

(1 file)

Attached patch patchSplinter Review
found while testing bug 475100... ${BrandFullName} needs to be quoted.

Requesting blocking since we are going to need this for branding.

mconnor, can I get you to review this (it is an extremely simple / safe patch)?
Flags: blocking-firefox3.1?
Attachment #359468 - Flags: review?(mconnor)
Can't add the Beta string in the installer without this fix so P1.
Priority: -- → P1
Target Milestone: --- → Firefox 3.1b3
Attachment #359468 - Flags: review?(mconnor) → review+
Flags: blocking-firefox3.1? → blocking-firefox3.1+
Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/09abc2219520

Pushed to mozilla-1.9.1
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/90f859401df9
Status: NEW → RESOLVED
Closed: 15 years ago
Keywords: fixed1.9.1
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: