476161 - Session restore on 1.9.1 branch (and maybe trunk) incorrectly restores state of some Google Reader elements

Status: VERIFIED FIXED

(Firefox :: Session Restore, defect)

Description

[Misak Khachatryan]

Attachment: problematic sessionstore.js example

When Firefox 3.1 restores Google Reader page, SELECT HTML element for selecting folders on the left of search is always restores expanded.

Steps to reproduce.
1. Open google reader page, read something and close firefox. You should have set option to restore last state in ff preferences.
2. Open Firefox again and it's restores reader page with Select folder expanded.

Same result for Seamonkey 2.0 trunk (also mozilla 1.9.1), to which i'm porting sessionstore. Firefox 3.0 works correct.

I don't thinks that's sessionstore problem, but i'm not sure, so it's worth to check and then triage.

Comment 1

[Nochum Sossonko [:Natch]]

Attachment: problematic session pretty-print

Comment 2

[Simon Bünzli]

Attachment: don't dispatch input events when the default value didn't change

The issue is that Google Reader reacts to input events which we dispatch even for blank textfields (for unchanged text fields to be precise). Since there's really no point in doing so, we can just stop dispatching input events in that case and be done. Tests are included.

Comment 3

[Dietrich Ayala (:dietrich)]

Comment on attachment 359799 [details] [diff] [review]
don't dispatch input events when the default value didn't change

r=me thanks!

Comment 4

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/b395701ced50

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 359799 [details] [diff] [review]
don't dispatch input events when the default value didn't change

a191=beltzner

Comment 6

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/ed64d408b4e2

Comment 7

[Aakash Desai [:aakashd]]

verified FIXED on builds:


Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2a1pre) Gecko/20090514 Minefield/3.6a1pre ID:20090514031229

and

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b5pre) Gecko/20090514 Shiretoko/3.5b5pre ID:20090514031203