476226 - Beep when closing prefwindow with cmd+w in apps without own close key defined

Status: RESOLVED FIXED

(Toolkit :: Preferences, defect)

Description

[Stefan [:stefanh]]

(Same as bug 473444, forgot about the close key)

STR:

1) Launch Calendar or Seamonkey
2) Open preferences
3) Hit Cmd+W

Expected result: Prefwindow closes silently
Actual results: Prefwindow closes with a beep

This affects apps that doesn't have a second close key defined (either in a menu or in preferences.xul). Actually, it shouldn't be necessary to have a <key/> in preferences.xul (like thunderbird have), since we have a keypress handler for this in preferences.xml...

Comment 1

[Stefan [:stefanh]]

Attachment: use stopPropagation and preventDefault on the handler

Last keypress handler in preferences.xml...

Comment 2

[Stefan [:stefanh]]

http://hg.mozilla.org/mozilla-central/rev/6076fd1df050

Comment 3

[Stefan [:stefanh]]

Comment on attachment 359846 [details] [diff] [review]
use stopPropagation and preventDefault on the handler

This fixes a quite annoying mac-specific problem that hits consumers of the preference widget. Should be safe.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 359846 [details] [diff] [review]
use stopPropagation and preventDefault on the handler

a191=beltzner

Comment 5

[Stefan [:stefanh]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/3097abd84cdf