Closed
Bug 476634
Opened 15 years ago
Closed 15 years ago
Storage template builder can't handle 64 bit integers
Categories
(Core :: XUL, defect)
Core
XUL
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: mossop, Assigned: mossop)
References
Details
Attachments
(1 file, 1 obsolete file)
|
6.80 KB,
patch
|
enndeakin
:
review+
|
Details | Diff | Splinter Review |
When the template builder encounters an integer in the result set it retrieves it as a 32 bit integer, truncating what may be a 64 bit integer.
|
Assignee | |
Comment 1•15 years ago
|
||
Ought to cover it
|
|
Assignee | |
Comment 2•15 years ago
|
||
Adds tests. We cannot test the largest 64 bit integers because JS can't handle them exactly, which perhaps might argue that supporting 64-bit is unnecessary, but I don't think so.
Assignee: nobody → dtownsend
Attachment #360299 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #360501 -
Flags: review?
|
|
Assignee | |
Updated•15 years ago
|
Attachment #360501 -
Flags: review? → review?(enndeakin)
|
||
Comment 3•15 years ago
|
||
Comment on attachment 360501 [details] [diff] [review] with tests Looks OK, but it would be good to put the tests in the same directory as bug 378893.
Attachment #360501 -
Flags: review?(enndeakin) → review+
|
|
Assignee | |
Comment 4•15 years ago
|
||
Not sure I understand, the tests are in the same directory, except that that directory doesn't exist yet since that bug isn't fixed.
|
|
Assignee | |
Comment 5•15 years ago
|
||
Moved the tests and landed in http://hg.mozilla.org/mozilla-central/rev/a55a3228e474
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
You need to log in
before you can comment on or make changes to this bug.
Description
•