476954 - Implement nsWindow::SetIcon for windows ce

Status: RESOLVED WONTFIX

(Core :: Widget: Win32, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

Currently the entire implementation is #ifdef'd out.

http://mxr.mozilla.org/mozilla-central/source/widget/src/windows/nsWindow.cpp#6564

Comment 1

[Doug Turner (:dougt)]

Attachment: patch v.1 (WIP)

work in progress patch for implementing SetIcon for windows ce.  the approach I took was to just use libpr0n to grab the ico file on disk, decode, then construct a HICON.  I wanted this to work on w32 as well, better testing converge, etc.

couple things that are broken.  i was hoping that each icon in the ico file would be a separate container.  right now, the decoder isn't doing that.  Also, on windows mobile (maybe ce too) the V4 bit map stuff is not supported.  Right now, we are not calling this stuff, but we should #ifdef it out instead of #defining the structures.  Lastly, i am not sure about the dwSize math when implementing CreateDIBitmap (i do not think we such always use 4 as the size to multiply h*w by).  as i said, work in progress.

Comment 2

[Doug Turner (:dougt)]

do you need this ?

can you check to see if chatzilla, when installed in Firefox, has a window icon on Windows CE?

Comment 3

[Doug Turner (:dougt)]

(this is not blocking fennec)

Comment 4

[Ed Morley [:emorley]]

WinCE/Windows Mobile support has been removed from the main build system, Spidermonkey, mobile installer, in-app updater and so on (see bug 614720, bug 554087 and all their dependants). Until such point where MS decide to release a Windows Phone 7 NDK and the decision is made to port to that platform, this is WONTFIX.

Filter bugmail on WinCEMassWONTFIX.