478380 - Need shortcut for "Compact Folder"

Status: RESOLVED WONTFIX

(Thunderbird :: Mail Window Front End, enhancement)

Description

[Hubert Figuiere [:hub]]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.6) Gecko/2009012700 SUSE/3.0.6-0.1.2 Firefox/3.0.6
Build Identifier: 

Compact folder need a shortcut. See Seamonkey bug 86161

Reproducible: Always

Comment 1

[Hubert Figuiere [:hub]]

Attachment: patch

Proposed to patch to add the shortcut to Thunderbird 3

Against HEAD.

Comment 2

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 362196 [details] [diff] [review]
patch

Hey hub, thanks for the patch!

We can't take this key code though since it's going to be a conflict.  The new search coming out of bug 474701 is planned to use the accel/ctrl-k for accessing the search entry.

Also we have been pushing, though not really successfully in this release, to fix bug 286888 and make compact folders automatic.

Comment 3

[Hubert Figuiere [:hub]]

I don't want it automatic. I want it to be done *when I want*, without having to use the pointing device. I don't use the default setting to deal with deleted mail, I use the "mark as deleted" setting. And I expect them to stay until I expunge.

If you allocate me a different shortcut I'll be happy to provide a new version of the patch.

Comment 4

[Hubert Figuiere [:hub]]

see comment 3

Comment 5

[Magnus Melin [:mkmelin]]

Also, that patch would do cmd_compactFolder, which is *all* folders... so it doesn't really do what you want.

Comment 6

[Hubert Figuiere [:hub]]

Good point. I think that's actually another bug. It is what the contextual menu provide I want to do... The one that is even harder to reach.

*sigh*

Comment 7

[Gervase Markham [:gerv]]

Ooh, yes please :-)

Gerv

Comment 8

[Bryan Clark (DevTools PM) [:clarkbw]]

Any suggestions for a new shortcut?  I haven't had much time to think about this.

Comment 9

[Ben Johnson]

The keyconfig extension can be used to create a shortcut to compact just the current folder. Add a new key with code of "gFolderTreeController.compactFolders();" and then bind it to any key you like. Works great for me.

http://getsatisfaction.com/mozilla_messaging/topics/how_can_i_compact_just_the_current_folder_when_the_message_list_has_focus

Comment 10

[Ludovic Hirlimann [:Usul]]

(In reply to comment #8)
> Any suggestions for a new shortcut?  I haven't had much time to think about
> this.

Bryan could you take a minute or two and come up with a key ?

Comment 11

[Jim Porter (:squib)]

Isn't folder compaction going to be largely irrelevant in 3.4 (or whatever version has pluggable mailstores and switches the default store to maildir)?

Comment 12

[Wayne Mery (:wsmwk)]

(In reply to comment #11)
> Isn't folder compaction going to be largely irrelevant in 3.4 (or whatever
> version has pluggable mailstores and switches the default store to maildir)?

Indeed. 

It's great that Hubert has put up a patch. But, restating bug 86161 comment 19 (and the comments which follow it are even more worth skimming) ... 

We should be (and have been) frugal in giving keys to functions that don't currently have them. If a key is to be assigned, the need should be significant. The use case mentioned here is "Mark as deleted", which is not a default setting/workflow in Thunderbird.  And sounds like it would only be used only a few times a day.  Beyond that, is there a significant benefit to having a key binding?  Neither this bug nor bug 86161, (with a mere 11 votes in 11 years) seems to indicate a widespread need. 

Also, the rational seems to imply that the use case is important enough for a key binding, but not for a button that takes up real estate - that seems like a disconnect.  

And there are alternatives.

Comment 13

[Hubert Figuiere [:hub]]

(In reply to comment #12)
> The use case mentioned here is "Mark as deleted", which is not a
> default setting/workflow in Thunderbird.  

The fact that it is not default on IMAP is another story. I do believe it should be too.

Comment 15

[Wayne Mery (:wsmwk)]

We want compact to go away, or be hidden, so I think it is fair to say that we wil never provide this.