478506 - Browser tests suite leaks after Session Restore feature landing

Status: VERIFIED FIXED

(SeaMonkey :: Session Restore, defect)

Description

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1234554170.1234559006.14466.gz
Linux comm-central dep unit test on 2009/02/13 11:42:50
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 268699 bytes during test execution (threshold set at 1112 bytes)

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1234553256.1234560447.16840.gz
MacOSX 10.4 comm-central dep unit test on 2009/02/13 11:27:36
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 251739 bytes during test execution (threshold set at 1232 bytes)

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1234554759.1234559933.15962.gz
Win2k3 comm-central dep unit test on 2009/02/13 11:52:39
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 267517 bytes during test execution (threshold set at 1112 bytes)

Regression timeframe:
http://hg.mozilla.org/comm-central/pushloghtml?startdate=2009-02-13+07%3A39%3A20&enddate=2009-02-13+10%3A51%3A17
I don't know which one of bug 36810 or bug 459550.

Comment 1

[Misak Khachatryan]

Patch for bug 478470 fixes leaks.

Comment 2

[Robert Kaiser]

The leak happens with undo closed tab data somehow, apparently the current session restore code holds on to it too long or so, but good to know that bug 478470 seems to fix it.
The browser chrome tests opens and closes tabs, which none of the others do, that's why we're only seeing the leak there.

Comment 3

[Robert Kaiser]

And sorry for one more bugspam, but I can confirm the bug 478470 patch fixing this leak.

Comment 4

[Serge Gautherie (:sgautherie)]

V.Fixed, as Windows tinderbox already turned green :-)