Closed Bug 478666 Opened 15 years ago Closed 15 years ago

trees should support three finger swipe up/down on Mac OS X

Categories

(Toolkit :: UI Widgets, defect)

Product:
Toolkit
Component:
UI Widgets
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.9.2a1

People

(Reporter: Mardak, Assigned: Mardak)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

v1
1.16 KB, patch
enndeakin
: review+
beltzner
: approval1.9.1-
Details | Diff | Splinter Review 
Swipe up/down could scroll to the top/bottom of trees.
Attached patch v1 — — Splinter Review 
Generalize to tree widgets..
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #362493 - Flags: review?(roc)
I'm not the right reviewer for toolkit.
Attachment #362493 - Flags: review?(roc) → review?(gavin.sharp)
Attachment #362493 - Flags: review?(gavin.sharp) → review?(enndeakin)
Attachment #362493 - Flags: review?(enndeakin) → review+
http://hg.mozilla.org/mozilla-central/rev/46424e50827c
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Sorry, but this doesn't work at all with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090221 Minefield/3.2a1pre Ubiquity/0.1.5 ID:20090221020633

Trees support swipe up/down like the Library one but do we need an extra handler for the about:config window?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → ASSIGNED
Depends on: 479662
Odd. I distinctively remember this working on about:config. But it totally makes sense why about:config doesn't work.. it's inside the browser element, and we stop propagation before it gets to the about:config document.

Switching this to just trees and filed bug 479662 about adjusting what can get gestures.
Blocks: 479662
Status: ASSIGNED → RESOLVED
Closed: 15 years ago → 15 years ago
No longer depends on: 479662
Resolution: --- → FIXED
Summary: about:config should support three finger swipe up/down on Mac OS X → trees should support three finger swipe up/down on Mac OS X
Alright. That looks great in the Library. Verified fixed with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090221 Minefield/3.2a1pre ID:20090221020633

Is this patch ready for 1.9.1?
Status: RESOLVED → VERIFIED
Attachment #362493 - Flags: approval1.9.1?
Attachment #362493 - Flags: approval1.9.1? → approval1.9.1-
Comment on attachment 362493 [details] [diff] [review]
v1

Needs tests, please renominate once you have 'em.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: