478714 - The names of the avm shell executables shall be 'avm' and 'avm64' on all platforms

Status: RESOLVED FIXED

(Tamarin Graveyard :: Build Config, defect)

Description

[Lars T Hansen]

Following discussion it has been decided that the avm shell executable shall be named 'avm' on all platforms (ie 'avm.exe' on windows).  This harmonization is part of the effort to make the shell more usable as a scripting environment (especially once eval shows up).

On 64-bit systems the executable shall be 'avm64', since it often ends up in the same directory as the 32-bit executable in cross-platform development environments.

As far as I know we need to update:

 - VC2008 project files
 - Xcode project files
 - configure.py
 - build bots etc that already know what the name of the executable is

Comment 1

[Lars T Hansen]

Edwin suggests naming the directories eg 'Release64' rather than naming the executable 'avm64'.

Comment 2

[Steven Johnson]

yeah, I'm not so sure about "avm64". Would be nice to be able to rely on using "avm" as a scripting command in all cases; seems like it would be desirable to have "avm" refer to the best version for the platform.

Comment 4

[Steven Johnson]

Reactivating this discussion... any votes on "Release64/avm" vs "Release/avm64"?

IMHO the former is a better option, but I could be persuaded.

Comment 5

[Lars T Hansen]

(In reply to comment #4)
> Reactivating this discussion... any votes on "Release64/avm" vs
> "Release/avm64"?
> 
> IMHO the former is a better option, but I could be persuaded.

I'm happy either way, as long as we don't build fat binaries that will trick us into running the 64-bit binary when the OS thinks that's the right thing to do.

Comment 6

[Steven Johnson]

(In reply to comment #5)
> I'm happy either way, as long as we don't build fat binaries that will trick us
> into running the 64-bit binary when the OS thinks that's the right thing to do.

Agreed. Let's hear if QE has strong feelings. (Also, note that cleanup to the buildbot scripts will have to be done to enable this; it probably makes sense for someone familiar with that to do the heavy lifting there...)

Comment 7

[James Sudduth]

Attachment: Bug 478714 XCode project patch

This is a 'preliminary' patch intended to elicit comments and feedback; there may be more to follow but this patch is focused on the XCode project file.

In order to build all avm shell executables as 'avm' the paradigm for building projects needed to be changed. Instead of several targets with different executable names, now there is one target with multiple configurations. This means that now you won't automatically get both a 32- and 64-bit shell when you build; also, the aggregated 32-64 shell target no longer exists. 

Architectures are i386/ppc for 32-bit and x86_64/ppc64 for 64-bit.

For 64-bit builds the sdk has been standardized on 10.5; 32-bit is still 10.4.

GCC has been kept at 4.0 for both 32- and 64-bit.

Comment 8

[James Sudduth]

Attachment: Bug 478714 Eclipse project patch

This is a 'preliminary' patch intended to elicit comments and feedback.

In order to build all avm shell executables as 'avm' the paradigm for building projects needed to be changed. There is still one target (shell) but now it has additional 64-bit configurations. The architecture for 32-bit continues to be i686; the new 64-bit configurations use x86_64. As before ppc isn't being built. For 64-bit builds the sdk has been standardized on 10.5; 32-bit is still 10.4. GCC has been kept at 4.0.1. New 64-bit launch configurations were added and the old ones were changed to find the renamed shell.

Comment 9

[James Sudduth]

Attachment: Bug 478714 VS Project patch

This is a 'preliminary' patch intended to elicit comments and feedback.

No new configurations were necessary. The shell was renamed to 'avm.exe'

Comment 10

[Simon Wilkinson]

(In reply to comment #8)
> Created attachment 462257 [details] [diff] [review]
> Bug 478714 Eclipse project patch

One issue I found: according to the indexer, editor and project properties, if I set one of the 64-bit configurations as the current build then __i386__ is still defined, rather than __x86_64__. (So the AVMSYSTEM_AMD64 ifdefs all appear as turned off).

However, when actually compiling,  __x86_64__ is defined.

Comment 11

[James Sudduth]

Attachment: Updated-to-tip patch

Comment 12

[Brent Baker]

Patch up the VTune build script in windows-deep to match up to the new name of the shell. Patch 5111:6b59194ba03a

Comment 13

[James Sudduth]

Attachment: Restore the aggregate 32- 64-bit Mac build functionality.

This patch restores the aggregate build target. It also rearranges the build configuration and target structures to be like they were before the last patch, while still accomplishing the goal of naming all the executables "avm". The major difference is that now instead of getting "shell" and "shell64" executables in the same folder, you will get "avm" execs in, for example, separate /Debug and /Debug64 folders.

Comment 14

[James Sudduth]

Whoops - should have reopened this before posting the patch.

Comment 15

[Lars T Hansen]

Comment on attachment 470610 [details] [diff] [review]
Restore the aggregate 32- 64-bit Mac build functionality.

Looks good - I tested it and everything was as expected.