Closed
Bug 479158
Opened 15 years ago
Closed 15 years ago
Double-tap zooming doesn't zoom in on the tapped element
Categories
(Firefox for Android Graveyard :: Panning/Zooming, defect)
Firefox for Android Graveyard
Panning/Zooming
Tracking
(fennec1.0b2+)
VERIFIED
FIXED
Tracking | Status | |
---|---|---|
fennec | 1.0b2+ | --- |
People
(Reporter: madhava, Assigned: crowderbt)
References
Details
Attachments
(1 file, 1 obsolete file)
3.85 KB,
patch
|
Gavin
:
review-
|
Details | Diff | Splinter Review |
When I doubletap to zoom, quite often nothing happens; sometimes, when something does happen, the result is that I'm left looking at a different part of the page than where I doubletapped, and page boundary is moved such that the page is cut off and there's no way to pan to see it. Some of this is related to bug 477105.
Reporter | ||
Updated•15 years ago
|
tracking-fennec: --- → ?
Reporter | ||
Updated•15 years ago
|
Updated•15 years ago
|
tracking-fennec: ? → 1.0b2+
Comment 1•15 years ago
|
||
Sounds like bug 477435. What is the build ID of the build you were testing?
Updated•15 years ago
|
Assignee: nobody → crowder
Assignee | ||
Comment 2•15 years ago
|
||
Madhava: what's your response to comment #1?
Comment 3•15 years ago
|
||
Comment 4•15 years ago
|
||
Attachment #375904 -
Attachment is obsolete: true
Comment 5•15 years ago
|
||
does this need r?
Assignee | ||
Comment 6•15 years ago
|
||
I assume so, but since it's basically a refactor of one I wrote, someone else should probably do it.
Assignee | ||
Comment 7•15 years ago
|
||
Comment on attachment 375906 [details] [diff] [review] fixed to use proper page size info I think Taras is in static-analysis land, so I'm'a try to get this landed.
Attachment #375906 -
Flags: review?(gavin.sharp)
Updated•15 years ago
|
Attachment #375906 -
Flags: review?(gavin.sharp) → review-
Comment 8•15 years ago
|
||
Comment on attachment 375906 [details] [diff] [review] fixed to use proper page size info >diff --git a/chrome/content/CanvasBrowser.js b/chrome/content/CanvasBrowser.js > viewportHandler: function viewportHandler(bounds, boundsSizeChanged) { >+ let cw = this._browser.contentWindow; this is unused >+ let [pageW, pageH] = this._effectiveContentAreaDimensions; can omit the pageH since it's also unused. >+ let endX = Math.min(elRect.x - margin, pageW - realWidth); This looks wrong, because realWidth is in page coordinates while pageW is in screen coordinates. Either way, this could use a more elaborate comment since this logic isn't easy to follow.
Comment 9•15 years ago
|
||
this is fixed
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment 10•15 years ago
|
||
verified FIXED on builds (zoom does occur): Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20090821 Fennec/1.0b3pre and Mozilla/5.0 (Macintosh; U; Intel Mac OSX 10.5; en-US; rv:1.9.2a2pre) Gecko/20090808 Fennec/1.0b3pre Bug 511898 was found in correspondence with verification of this one.
Status: RESOLVED → VERIFIED
Updated•14 years ago
|
Component: General → Panning/Zooming
You need to log in
before you can comment on or make changes to this bug.
Description
•