Closed Bug 479588 Opened 15 years ago Closed 15 years ago

Error console's text box should always be LTR

Categories

(Toolkit Graveyard :: Error Console, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

(Keywords: fixed1.9.1, rtl)

Attachments

(1 file, 2 obsolete files)

Error console's text box should always be LTR, even for RTL elements, because the code entered into it is LTR.  We should probably add the uri-element class to it.  Patch forthcoming.
Attached patch Patch (v1) (obsolete) — Splinter Review
Attachment #363471 - Flags: review?(dao)
Attachment #363471 - Flags: review?(dao) → review+
Comment on attachment 363471 [details] [diff] [review]
Patch (v1)

That line should wrap. While you're at it, you could add a semicolon in onkeypress and remove value="".
Personally I'd rather make it LTR in components/console/content/console.css. uri-element isn't quite right, although I don't foresee that this could cause any trouble.
Attached patch Patch (v2) (obsolete) — Splinter Review
Attachment #363471 - Attachment is obsolete: true
Attachment #366197 - Flags: review?(dao)
Attachment #366197 - Flags: review?(dao) → review-
Comment on attachment 366197 [details] [diff] [review]
Patch (v2)

I think you want #TextboxEval, and there's probably no need for !important.
Attached patch Patch (v3)Splinter Review
Yes, you're right.
Attachment #366197 - Attachment is obsolete: true
Attachment #366200 - Flags: review?(dao)
Attachment #366200 - Flags: review?(dao) → review+
http://hg.mozilla.org/mozilla-central/rev/6760e7395b5a
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Comment on attachment 366200 [details] [diff] [review]
Patch (v3)

Small theme-only change useful for RTL locales.
Attachment #366200 - Flags: approval1.9.1?
Comment on attachment 366200 [details] [diff] [review]
Patch (v3)

a191=beltzner
Attachment #366200 - Flags: approval1.9.1? → approval1.9.1+
No longer blocks: intl.css-cleanup
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: