479645 - about:rights infobar and about:right page use "open software" and "open source software" inconsistently

Status: VERIFIED FIXED

(Firefox :: General, defect, P2)

Description

[David Ascher (:davida)]

Attachment: screenshot (mac)

In http://mxr.mozilla.org/comm-central/source/mozilla/browser/locales/en-US/chrome/browser/aboutRights.dtd#5

we have:

  <!ENTITY rights.intro "&brandFullName; is free and open source software, built by a community of thousands from all over the world. There are a few things you should know:">

but in http://mxr.mozilla.org/comm-central/source/mozilla/browser/locales/en-US/chrome/browser/aboutRights.properties?raw=1&ctype=

we have:

  notifyText = %S is free and open software from the non-profit Mozilla Foundation.

Note "open software", not open source software.  I'm suspecting that that's not an intentional difference, and that the latter should read "open source software".

(Cc'ing some of the Tb drivers as Thunderbird has the same bug, and probably wants to follow whatever is decided here.)

(I didn't check to see if this was fixed in the 1.9.1 branch, as mxr on that branch isn't working for me right now)

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

http://mxr.mozilla.org/mozilla1.9.1/source/browser/locales/en-US/chrome/browser/aboutRights.properties?raw=1&ctype=

says:

notifyText = %S is free and open software from the non-profit Mozilla Foundation.

which is the text as given in bug 456439 (see attachment 339841 [details]). Changing it would be late-l10n if we take it for Firefox 3.1, which is doable, we just need to know right away.

Harvey/Kev: any strong opinions here? I actually thought "free and open" was intentional (and fine on its own) but I suppose we ought to be consistent.

Comment 2

[harvey anderson]

Prefer "free and open source software" and "...built by a community of thousands..."

/hja

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Don't think this blocks, but I'll fix it tomorrow.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: free and open source software

Wording fix as per hja's comment. Also renamed the entity and had to adjust some spacing.

Comment 5

[Axel Hecht [:Pike]]

Comment on attachment 364151 [details] [diff] [review]
free and open source software

I'm not a superreviewer, but I'm happily granting an additional review on this patch.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Yeah, I was looking for l10n-happy-stamp, really, to make sure you agreed we needed to rev the entity. Thanks.

Marking checkin-needed, as Daddy doesn't let me have checkin access.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/mozilla-central/rev/ee49a98d2646

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 364151 [details] [diff] [review]
free and open source software

a191=beltzner

Comment 9

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/f071b8ea6ba7

Comment 10

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.2pre)
Gecko/20090727 Shiretoko/3.5.2pre ID:20090727031954

and

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre)
Gecko/20090727 Minefield/3.6a1pre ID:20090727031437