480281 - Gloda - Occasional test_index_messages.js failures on Linux & Mac Tinderboxes

Status: RESOLVED FIXED

(MailNews Core :: Database, defect)

Description

[Mark Banner (:standard8)]

For a while now, we've been seeing occasional failures of test_index_messages.js on the tinderboxes (prob 2-3 times a day, I've just been slow in reporting).

Here's the latest log:

NEXT ERROR TEST-UNEXPECTED-FAIL | ../../../../mozilla/_tests/xpcshell/test_mailnewsglobaldb/unit/test_index_messages.js | test failed, see log
../../../../mozilla/_tests/xpcshell/test_mailnewsglobaldb/unit/test_index_messages.js.log:
>>>>>>>
2009-02-26 01:27:19	gloda.NS	INFO	Logging Initialized
2009-02-26 01:27:19	gloda.datastore	DEBUG	Beginning datastore initialization.
2009-02-26 01:27:19	gloda.datastore	DEBUG	Creating database because it does't exist.

 Skipping 350 Lines...

2009-02-26 01:27:22	gloda.indexer	DEBUG	Entering folder: mailbox://nobody@Local%20Folders/Inbox
2009-02-26 01:27:22	gloda.indexer	DEBUG	*** Indexing message: 3610 : Red Document Needs Attention
2009-02-26 01:27:22	gloda.indexer	DEBUG	  * Got Mime Message!
2009-02-26 01:27:22	gloda.ds.mbm	DEBUG	getting results...
2009-02-26 01:27:22	gloda.ds.mbm	DEBUG	query completed, notifying... Message:11,
2009-02-26 01:27:22	gloda.indexer	DEBUG	ancestors raw: Message:11,
2009-02-26 01:27:22	gloda.indexer	DEBUG	ref len: 2 anc len: 2
2009-02-26 01:27:22	gloda.indexer	DEBUG	references: 0 = [e-mail],1 = [e-mail]
2009-02-26 01:27:22	gloda.indexer	DEBUG	ancestors: 0 = Message:11,1 = 
2009-02-26 01:27:22	gloda.indexer	DEBUG	0 candidate messages
2009-02-26 01:27:22	gloda.datastore	DEBUG	CreateMessage: 1, 3610, 5, 949435200000000, [e-mail]
2009-02-26 01:27:22	gloda.NS	INFO	 ** grokNounItem: message
2009-02-26 01:27:22	gloda.NS	INFO	  * provider: gloda.fundattr
2009-02-26 01:27:22	gloda.datastore	DEBUG	QUERY FROM QUERY: SELECT * FROM identities WHERE (id IN (SELECT id FROM identities WHERE (kind = ?) AND (value = ? OR value = ?))) ARGS: email,[e-mail],[e-mail]
2009-02-26 01:27:22	gloda.NS	DEBUG	 found identity for 'Johnny Jones' ([e-mail])
2009-02-26 01:27:22	gloda.NS	DEBUG	 found identity for 'Idina Ivarsson' ([e-mail])
2009-02-26 01:27:22	gloda.NS	INFO	  * provider: gloda.explattr
2009-02-26 01:27:22	gloda.NS	INFO	  * optimizer: gloda.fundattr
2009-02-26 01:27:22	gloda.NS	INFO	 ** done with providers.
2009-02-26 01:27:22	gloda.NS	DEBUG	  json text: {"8":9,"9":[10],"10":[],"20":false,"21":false,"19":[],"13":[9,10]}
2009-02-26 01:27:22	gloda.NS	DEBUG	 inserting item
2009-02-26 01:27:22	gloda.NS	DEBUG	 adjusting attributes, add: 8,9,9,10,20,0,21,0,13,9,13,10 rem: 
@@@ messageCollectionListener.onItemsAdded
2009-02-26 01:27:22	gloda.NS	DEBUG	 done grokking.
2009-02-26 01:27:22	gloda.indexer	INFO	--- Done indexing, disabling timer renewal.
((( indexer notification (2 messages) about to verify: allMessageInSameConversation and complete: _permutationIndexed
>>> enter driveFakeServer
  resetting fake server
  issuing GetNewMail
*** exiting
NEXT ERROR *** TEST-UNEXPECTED-FAIL | /buildbot/linux-comm-central-check/build/mozilla/../mailnews/db/gloda/test/resources/glodaTestHelper.js | [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIPop3Service.GetNewMail]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: /buildbot/linux-comm-central-check/build/mozilla/../mailnews/db/gloda/test/resources/glodaTestHelper.js :: driveFakeServer :: line 412"  data: no]
JS frame :: /buildbot/linux-comm-central-check/build/mozilla/testing/xpcshell/head.js :: do_throw :: line 109
JS frame :: /buildbot/linux-comm-central-check/build/mozilla/../mailnews/db/gloda/test/resources/glodaTestHelper.js :: driveFakeServer :: line 418
JS frame :: /buildbot/linux-comm-central-check/build/mozilla/testing/xpcshell/head.js :: anonymous :: line 70
JS frame :: /buildbot/linux-comm-central-check/build/mozilla/testing/xpcshell/head.js :: anonymous :: line 70
  draining events
  draining events
<<< exit driveFakeServer
*** FAIL ***

<<<<<<<
TEST-PASS | ../../../../mozilla/_tests/xpcshell/test_mailnewsglobaldb/unit/test_query_messages.js | all tests passed
NEXT ERROR gmake[4]: *** [check] Error 1

http://tinderbox.mozilla.org/showlog.cgi?log=Thunderbird/1235639537.1235640267.17677.gz

As far as I know we're not seeing the error with getting pop3 mail in the other tests that use GetNewMail, so I'm guessing this is something wrong with the gloda test or the gloda implementation.

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

Attachment: v1 don't use the fake server, we can use nsIMsgLocalMailFolder.addMessage

We only used the fake server because I didn't know about nsIMsgLocalMailFolder.addMessage at the time.

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

pushed: http://hg.mozilla.org/comm-central/rev/817f5e4bd44f