480318 - [FIX]"Save Page As" doesn't give the filename of the bugzilla attachment

Status: RESOLVED FIXED

(Firefox :: File Handling, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

When using Save Page As with bugzilla attachments, the default filename is attachment.cgi, not the real file name.

Comment 1

[Boris Zbarsky [:bzbarsky]]

This is totally my fault.  Gotta love try/catch.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: I wish we had tests for this

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 364318 [details] [diff] [review]
I wish we had tests for this

:(

Comment 4

[Phil Ringnalda (:philor)]

Is there actually more than one expected error, so the catch block can't just check for that and rethrow any other errors?

Comment 5

[Boris Zbarsky [:bzbarsky]]

Dunno.  Looking at nsDOMWindowUtils::GetDocumentMetadata I wouldn't expect this code to ever get an exception to start with, so I have no idea why someone stuck a try/catch here.

Comment 6

[Phil Ringnalda (:philor)]

Looks to me like we'll have to ask you either way: bug 263697 first, then bug 264757.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Ah, that first checkin had the try/catch because the "get to window utils" part could throw.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Pushed http://hg.mozilla.org/mozilla-central/rev/707ad9ee494a