480378 - river view reloads when traversed in page history

Status: RESOLVED FIXED

(Mozilla Labs :: Snowl, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

When you go back or forward through page history to the river view, it now reloads the view.  It looks like this is a regression from a recent change that added an unload handler to the collections view, which disables the bfcache <https://developer.mozilla.org/en/Using_Firefox_1.5_caching>.

Since it can take time to build the river view, and we want to preserve the user's place in it when they traverse page history, it should be cacheable by the bfcache, so there shouldn't be an unload handler in it.

Comment 1

[alta88]

ah yes.  in the case of closing river (via closing tab or the button) we do need to run the unload handlers.  but in the case of page back/forward, we don't.  an onunload is sent in both cases..

i'll take a look at smartening this up.

Comment 2

[alta88]

fixed bd1214988d41.