48051 - Restart dialog needs title

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect, P2)

Description

[Henrik Gemal]

The restart dialog that you sometimes are presented for in the installer needs a 
title. Currently it's just a titleless dialog.

Comment 1

[Sean Su]

over to Ying?

Comment 2

[Ying-Lin Xia]

Attachment: Patch to add the window title

Comment 3

[Sean Su]

Comment on attachment 64931 [details] [diff] [review]
Patch to add the window title

r=ssu

Comment 4

[Ying-Lin Xia]

Attachment: One patch to fix both dialog title bugs, bug 48051 & bug 67067

bragg: "Technically they're both "clean-up" type bugs and they're both in the 
same sub-system (the install wizard).  I believe that there would actually be 
less chance of error in a single check-in than if it was split into 2. I think 

would be the safest (and most efficient by the way) checkin procedure for these

two bugs."

Comment 5

[Daniel Veditz [:dveditz]]

Comment on attachment 65122 [details] [diff] [review]
One patch to fix both dialog title bugs, bug 48051 & bug 67067

>     char szPort[MAX_BUF];
>     char szUserId[MAX_BUF];
>     char szPassword[MAX_BUF];
>     char szSelectDirectory[MAX_BUF];
>     char szDirectories_[MAX_BUF];
>     char szDrives_[MAX_BUF];
>     char szStatus[MAX_BUF];
>     char szFile[MAX_BUF];
>     char szUrl[MAX_BUF];
>     char szTo[MAX_BUF];
>     char szAccept_[MAX_BUF];
>     char szNo_[MAX_BUF];
>     char szProgramFolder_[MAX_BUF];
>     char szExistingFolder_[MAX_BUF];
>     char szSetupMessage[MAX_BUF];
>+    char szRestart[MAX_BUF];
>     char szYesRestart[MAX_BUF];
>     char szNoRestart[MAX_BUF];
>     char szAdditionalComponents_[MAX_BUF];
>     char szDescription[MAX_BUF];
>     char szTotalDownloadSize[MAX_BUF];
>     char szSpaceAvailable[MAX_BUF];
>     char szComponents_[MAX_BUF];
>     char szDestinationDirectory[MAX_BUF];
>     char szBrowse_[MAX_BUF];
>     char szCurrentSettings[MAX_BUF];
>     char szInstall_[MAX_BUF];
>     char szDelete_[MAX_BUF];
>     char szExtracting[MAX_BUF];
>     char szReadme_[MAX_BUF];
>     char szPause_[MAX_BUF];

The amount of memory this represents is insane!

sr=dveditz, though

Comment 6

[Curt Patrick (gone)]

Ying, this has been reviewed and super-reviewed.  Do you want me to check it in
for you?

Comment 7

[rchen]

Curt, Please checkin for Ying. Ying is on vacation. Thanks.

Comment 8

[Henrik Gemal]

this never got checked in.
to reproduce:
start the talkback.exe and leave it open while installing mozilla.

the dialog is title less and says:
"Setup has finished..."

shouldn't is say "Mozilla Setup has finished..."

20020302

Comment 9

[Jaime Rodriguez, Jr.]

Ying is this needed for MachV? If yes, please work with your manager to get this
one nsbeta1+.

Comment 10

[scottputterman]

Moving Netscape owned 0.9.9 and 1.0 bugs that don't have an nsbeta1, nsbeta1+,
topembed, topembed+, Mozilla0.9.9+ or Mozilla1.0+ keyword.  Please send any
questions or feedback about this to [e-mail].  You can search for
"Moving bugs not scheduled for a project" to quickly delete this bugmail.

Comment 11

[Curt Patrick (gone)]

I'll take care of getting this checked in, once we get the nsbeta1 plussed, and
look into the other titleless dialog that Henrik identified.

Comment 12

[Ying-Lin Xia]

I'm testing the patch again since it's old, and now I got Restart dialog always showing up at the end of installation. Still looking at it...

Comment 13

[Ying-Lin Xia]

ssu, would you please take a look at this simple patch again?
It's very strange now. After I put the changes in the lastest build, and 
rebuild the setup.exe, looks like everything in installGui will be messed up, 
and the restart dialog will always show up. To me, it seems a memory problem.
Please help, Thanks!

Comment 14

[Henrik Gemal]

the restart text also refers to "the program". Could we please change that 
into "Mozilla"...

Comment 15

[selmer (gone)]

Please update this bug with an [adt1] - [adt3] impact rating (or take it off the
list if it doesn't even rate adt3.)  Thanks!

Comment 16

[Sean Su]

Comment on attachment 65122 [details] [diff] [review]
One patch to fix both dialog title bugs, bug 48051 & bug 67067

I've tested the patch and it works just fine.

Comment 17

[Asa Dotzler [:asa]]

Comment on attachment 65122 [details] [diff] [review]
One patch to fix both dialog title bugs, bug 48051 & bug 67067

a=asa (on behalf of drivers) for checkin to 1.4b.

Comment 18

[Sean Su]

patch will be checked in along with bug 203194.

Comment 19

[Sean Su]

patch checked in again.

Comment 20

[Grace Bush]

verified - build 2003050211