480535 - [c3d] canvas.toDataURL doesn't work for non-2d contexts

Status: RESOLVED DUPLICATE of bug 528042

(Core :: Graphics: CanvasWebGL, defect)

Description

[Ilmari Heikkinen]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2a1pre) Gecko/20090227 Minefield/3.2a1pre
Build Identifier: 

canvas.toDataURL doesn't work for non-2d contexts because nsHTMLCanvasElement::ToDataURLImpl uses "2d" as the context id to get the context to GetInputStream from.

It should rather use mCurrentContextId as the context id for getting the context.

Reproducible: Always

Steps to Reproduce:
1. canvas.getContext("moz-glweb20")
2. canvas.toDataURL()

Actual Results:  
Error in JavaScript console, due to it trying to get the 2d context for the canvas to read from. Which fails.

Expected Results:  
It should return the image/png data URL for the contents of the GL canvas.

Comment 1

[Ilmari Heikkinen]

Attachment: Makes nsHTMLCanvasElement::ToDataURLImpl use mCurrentContextId for getting the context to read from

Makes toDataURL work for non-2d contexts.

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 364512 [details] [diff] [review]
Makes nsHTMLCanvasElement::ToDataURLImpl use mCurrentContextId for getting the context to read from

Thanks for catching this..  also feel free to set review? on me (:vlad) on patches that are ready to go, and I'll give them a look over :)

This looks fine, though I'm wondering what we should do if there's no attached context to the canvas.  I'd probably rather throw an error, so maybe check is mCurrentContextId.IsEmpty() and just return NS_ERROR_FAILURE... then mCurrentContextId can be used instead of ctxId.

Comment 3

[Ilmari Heikkinen]

Attachment: context id fix, now errors if there's no current context id

Comment 4

[Benoit Jacob [:bjacob] (mostly away)]

what's the status of this? is this a dup with 528042 ?

Comment 5

[Ilmari Heikkinen]

Yeah, this is a dup.