Closed
Bug 480745
Opened 15 years ago
Closed 12 years ago
Remove XP_MAC from mozilla/security
Categories
(Core :: Security: PSM, defect)
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: xfsunoles, Assigned: Usul)
References
()
Details
(Whiteboard: [psm-easy])
Attachments
(1 file, 1 obsolete file)
4.34 KB,
patch
|
briansmith
:
review+
KaiE
:
superreview+
|
Details | Diff | Splinter Review |
No description provided.
Comment 1•15 years ago
|
||
Notes:
1. We're talking about removing XP_MAC, not XP_MACOSX
2. XP_MAC code is code for the old pre-OSX versions of MacOS
3. The code must be removed from the right repositories.
For NSPR and NSS, the CVS repository is still the master upstream
repository.
4. According to
> http://mxr.mozilla.org/security/search?string=XP_MAC&case=on&find=mozilla%2Fsecurity%2F&findi=&filter=XP_MAC%5Cb&hitlimit=&tree=security
all the remaining occurrences of XP_MAC are in PSM, not in NSS,
so I am reassigning this bug to PSM.
Assignee: nobody → kaie
Component: Libraries → Security: PSM
OS: Mac OS X → Mac System 9.x
Product: NSS → Core
QA Contact: libraries → psm
Hardware: x86 → PowerPC
Version: trunk → unspecified
Comment 2•15 years ago
|
||
To clarify, according to that URL in the previous comment, all the remaining occurrences of XP_MAC under mozilla/security are in PSM, not in NSS.
Summary: Remove XP_MAC from /security → Remove XP_MAC from mozilla/security
Updated•14 years ago
|
Assignee: kaie → nobody
Whiteboard: [psm-easy]
Assignee | ||
Comment 3•13 years ago
|
||
Removing XP_Mac , based on mxr queries.
Assignee | ||
Updated•13 years ago
|
Attachment #529942 -
Flags: review? → review?(nelson)
Assignee | ||
Updated•13 years ago
|
Attachment #529942 -
Flags: review?(nelson) → review?(bsmith)
Assignee | ||
Comment 4•13 years ago
|
||
Bryan, review ping
Comment 5•13 years ago
|
||
Attachment #529942 -
Attachment is obsolete: true
Attachment #578863 -
Flags: superreview?(kaie)
Attachment #578863 -
Flags: review+
Attachment #529942 -
Flags: review?(bsmith)
Updated•12 years ago
|
Attachment #578863 -
Flags: superreview?(kaie) → superreview+
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Comment 6•12 years ago
|
||
Pushing without Try results since this is dead code removal. Note that the code in nsNSSIOLayer.cpp was already removed elsewhere in the last 8 months. https://hg.mozilla.org/integration/mozilla-inbound/rev/b15957ea2fba Ludovic, to make life easier in the future, please make sure that your hg is configured to generate all the needed metadata for checkin. Thanks! https://developer.mozilla.org/en-US/docs/Creating_a_patch_that_can_be_checked_in
Flags: in-testsuite-
Keywords: checkin-needed
Comment 7•12 years ago
|
||
(In reply to Ryan VanderMeulen from comment #6) > Pushing without Try results since this is dead code removal. Note that the > code in nsNSSIOLayer.cpp was already removed elsewhere in the last 8 months. > Well, that was clearly a bad decision. This lit up the tree nicely. Try next time kthxbye. Bustage fix. https://hg.mozilla.org/integration/mozilla-inbound/rev/ef116cb88c2a
Assignee | ||
Comment 8•12 years ago
|
||
(In reply to Ryan VanderMeulen from comment #6) > Pushing without Try results since this is dead code removal. Note that the > code in nsNSSIOLayer.cpp was already removed elsewhere in the last 8 months. > > https://hg.mozilla.org/integration/mozilla-inbound/rev/b15957ea2fba > > Ludovic, to make life easier in the future, please make sure that your hg is > configured to generate all the needed metadata for checkin. Thanks! > https://developer.mozilla.org/en-US/docs/ > Creating_a_patch_that_can_be_checked_in I would if this wasn't cvs code :-)
Assignee | ||
Comment 9•12 years ago
|
||
Oups my bad.
Comment 10•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b15957ea2fba https://hg.mozilla.org/mozilla-central/rev/ef116cb88c2a
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in
before you can comment on or make changes to this bug.
Description
•