480953 - Identity button should appear pressed when opening the identity popup

Status: VERIFIED FIXED

(Firefox :: Theme, enhancement)

Description

[Dão Gottwald [:dao]]

Attachment: patch

We can't make the identity button a proper menu button as the favicon needs to be a drag source, but we can set and use the "open" attribute nevertheless.

Pinstripe already tries to use that attribute to some extent, and I'd like to use it for Winstripe as well.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 364907 [details] [diff] [review]
patch

>diff --git a/browser/themes/pinstripe/browser/browser.css b/browser/themes/pinstripe/browser/browser.css

>-#identity-box:active > #page-proxy-stack,
>+#identity-box:hover:active > #page-proxy-stack,
> #identity-box[open="true"] > #page-proxy-stack {
>   opacity: 0.75;
> }

Does this even do anything? I can't notice the difference...

Comment 2

[Jo Hermans]

dupe of bug 414473 (mac), but there's also bug 417079 (linux) and bug 431983 (windows)

Comment 4

[Markus Stange [:mstange]]

(In reply to comment #1)
> (From update of attachment 364907 [details] [diff] [review])
> >diff --git a/browser/themes/pinstripe/browser/browser.css b/browser/themes/pinstripe/browser/browser.css
> 
> >-#identity-box:active > #page-proxy-stack,
> >+#identity-box:hover:active > #page-proxy-stack,
> > #identity-box[open="true"] > #page-proxy-stack {
> >   opacity: 0.75;
> > }
> 
> Does this even do anything? I can't notice the difference...

These selectors don't match because there's a hbox between #identity-box and #page-proxy-stack.

Comment 5

[Dão Gottwald [:dao]]

OK, apparently nobody missed that effect, so I'll remove these lines. Please file a new bug if you think we should make that work properly.

Comment 6

[Dão Gottwald [:dao]]

Attachment: landed patch

Comment 7

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/d4826b6af7a6

Comment 8

[Marcia Knous [:marcia]]

Verified fixed on the trunk using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090303 Minefield/3.2a1pre as well as the latest nightly on 10.4. The shading ends up a bit dark, but I would have to see how it compares to the other OS's.

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 364974 [details] [diff] [review]
landed patch

a191=beltzner

Comment 10

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/86b0c8a3a9f1

Comment 11

[Marcia Knous [:marcia]]

Verified fixed on the 1.9.1 branch using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b4pre) Gecko/20090423 Shiretoko/3.5b4pre. Adding keyword.

Comment 12

[Alex Faaborg [:faaborg] (Firefox UX)]

This bug's priority relative to the set of other polish bugs is:
P1 - Polish issue that appears in the main window, or is something that the user may encounter several times a day.