Closed Bug 481063 Opened 15 years ago Closed 15 years ago

Website: Slice 'View Personas' page

Categories

(Mozilla Labs Graveyard :: Personas Plus, defect, P1)

defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: rdoherty, Assigned: telliott)

References

()

Details

Attachments

(1 file)

Sliced design should show up here soon:

https://sm-weave-proxy01.services.mozilla.com/store/viewpersonas_tmpl.html#
Assignee: rdoherty → telliott
IE 7 is complaining about this code:

203    <script type="text/javascript" charset="utf-8">
204        $(document).ready(function() {
205            $("#gallery").previewPersona()
206        });
207    </script>

"Object doesn't support this property or method" in line 205, which makes sense, since we're only expecting that Firefox users can use JS to dynamically preview Personas, but I just thought I'd mention it.
Error: illegal XML character
Source File: https://sm-weave-proxy01.services.mozilla.com/store/js/script.js
Line: 108, Column: 3
Source Code:
<<<<<<< local

clouserw confirmed that it's a bad merge.
Error: $("#gallery").previewPersona is not a function
Source File: https://sm-weave-proxy01.services.mozilla.com/store/viewpersonas_tmpl.html
Line: 205
(In reply to comment #3)
> Error: illegal XML character
> Source File: https://sm-weave-proxy01.services.mozilla.com/store/js/script.js
> Line: 108, Column: 3
> Source Code:
> <<<<<<< local
> 
> clouserw confirmed that it's a bad merge.

Ok, then Toby should just remove the local changes and re-pull.
cleaned out the .js files and repulled
I see the following JS error in IE6-

Error:'undefined' is null or not an object
Line:102
Char:3
Code:0
URL:https://sm-weave-proxy01.services.mozilla.com/store/viewpersonas_tmpl.html
(In reply to comment #7)
> Created an attachment (id=365936) [details]
> JS-err-line102-undefined is null or not not an object
> 
> I see the following JS error in IE6-
> 
> Error:'undefined' is null or not an object
> Line:102
> Char:3
> Code:0
> URL:https://sm-weave-proxy01.services.mozilla.com/store/viewpersonas_tmpl.html

Please file this as a separate bug for tracking. (Same product, component & Website: prefix), thanks!
Priority: -- → P1
Hmm, appear to have accidentally crossed streams between this and bug 481064!

From there:
======

So that we're able to test the dynamic generation as well as the static
generation, the dynamic page will be at:

https://sm-weave-proxy01.services.mozilla.com/store/dynamic/All/Popular

The static pages will start at 

https://sm-weave-proxy01.services.mozilla.com/store/gallery/All/Popular

and can be browsed from there.

====

Ryan's template can be seen at 

https://sm-weave-proxy01.services.mozilla.com/redesign/viewpersonas_tmpl.html
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Just a note. The dynamic page has moved to https://sm-weave-proxy01.services.mozilla.com/store/dynamic/gallery/All/Popular

to make room for the dynamic main index page
Verified FIXED (slice); I ran it through a link checker in addition to clicking through the links manually.

Will be filing followup bugs as I find them.
Target Milestone: -- → 1.0
Product: Mozilla Labs → Mozilla Labs Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: