481249 - Archiving doesn't work in the stand-alone message viewer

Status: RESOLVED FIXED

(Thunderbird :: Message Reader UI, defect)

Description

[Nomis101]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_5_6; de-de) AppleWebKit/528.16 (KHTML, like Gecko) Version/4.0 Safari/528.16
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090218 Thunderbird/3.0b2

If you open your mail in the stand-alone message viewer the "Archive - A" is greyed out in the menu (and so the shortcut doesn't work). But it works if you click on the Archive button in the message header.

Reproducible: Always

Steps to Reproduce:
1. Double click on a message to open it in the stand-alone message viewer
2. Look at the menu or try to archive it with the "A" shortcut

Actual Results:  
"Archive" is greyed out in the menu and the shortcut doesn't work

Comment 1

[rsx11m]

Confirmed, only the "archive" button works in a stand-alone message reader. Nothing filed yet [Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b3pre) Gecko/20090223 Thunderbird/3.0b2].

Comment 2

[Phil Ringnalda (:philor)]

Would have already been done with this, except I hit the surprising bit where we disable and enable the archive button based on whether you're in the archive folder or not, but don't change the menuitem, which is giving me pause.

Comment 3

[Phil Ringnalda (:philor)]

Attachment: Fix

Ah, apparently having the archive menuitem enabled even when the button isn't is intentional, though it's not obvious from bug 473215 whether it's intentional for The davida Problem of having moved things into /Archives manually, and then wanting to move them to the proper place, or for some other reason. That doesn't feel very settled, so this patch just follows along for now, leaving the menuitem enabled even when you open an already-archived message in a standalone window.

Comment 4

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/comm-central/rev/4a8ddefbf08e