Closed
Bug 482161
Opened 15 years ago
Closed 15 years ago
SaveHeaderSniffer fails to save "untitled" pages in a localizable way
Categories
(Camino Graveyard :: Downloading, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bugzilla-graveyard, Assigned: bugzilla-graveyard)
References
()
Details
Attachments
(1 file, 1 obsolete file)
1.54 KB,
patch
|
stuart.morgan+bugzilla
:
superreview+
|
Details | Diff | Splinter Review |
http://mxr.mozilla.org/mozilla/source/camino/src/download/SaveHeaderSniffer.mm#282 There's a comment in the code requesting that we localize this, so I did. Do we want to take this for 2.0?
Attachment #366233 -
Flags: review?(alqahira)
Assignee | ||
Updated•15 years ago
|
Assignee: nobody → cl-bugs-new
Status: NEW → ASSIGNED
Comment on attachment 366233 [details] [diff] [review] fix v1.0 Given that an untitled document in the OS has a title of "Untitled" and a default save name suggestion of "Untitled", we should do the same thing and just use the existing string here, too. r=me with that change.
Assignee | ||
Comment 2•15 years ago
|
||
The previous patch didn't build because apparently macros don't like Obj-C syntax as input :-p This one builds and works as expected, and addresses Smokey's other comment.
Attachment #366233 -
Attachment is obsolete: true
Attachment #366238 -
Flags: superreview?(stuart.morgan+bugzilla)
Attachment #366233 -
Flags: review?(alqahira)
Updated•15 years ago
|
Attachment #366238 -
Flags: superreview?(stuart.morgan+bugzilla) → superreview+
Comment 3•15 years ago
|
||
Comment on attachment 366238 [details] [diff] [review] fix v1.1 sr=smorgan
Comment 4•15 years ago
|
||
(In reply to comment #2) > The previous patch didn't build because apparently macros don't like Obj-C > syntax as input :-p Macros are just preprocessor string replacements, so I'm not sure what this means. Whatever problem you were having was presumably due to the fact that you were trying to use a macro designed for string literals on a method call.
Landed on cvs trunk.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•