482218 - [Port Bug 479899 to SeaMonkey Modern] s/#autoscroller/.autoscroller/g

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Philip Chee]

> There are a number of places in the toolkit theme where id selectors are
> used for some reason. These should be investigated and moved/removed.

> On all platforms, the #autoscroller should be a class.

Comment 1

[[e-mail]]

Note: a) at least for our purposes, the id is being retained
b) there's no indication that the patch will land on branch.

Comment 2

[Philip Chee]

I don't see where we use #autoscroller ?
<http://mxr.mozilla.org/comm-central/search?string=autoscroller>

Comment 3

[Philip Chee]

Oh I missed /mozilla/toolkit/content/widgets/browser.xml.

So what happens when we have nightly trunk builds but haven't branched comm-central?

Comment 4

[[e-mail]]

So, I misread the code, and even if we ported bug 386949 that would fix autoscrolling only in tabbrowser, not in other windows.

Presumably to support both sorts of builds we'd need both selectors.

Comment 5

[Robert Kaiser]

(In reply to comment #3)
> So what happens when we have nightly trunk builds but haven't branched
> comm-central?

We have no plans to do that, so far. (Just as a note)

Comment 6

[[e-mail]]

We've branched, so this can be fixed properly now!

Comment 7

[Edmund Wong (:ewong)]

Attachment: Changed #autoscroller to .autoscroller in global.css [Checkin: comment 8]

Comment 8

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 448002 [details] [diff] [review]
Changed #autoscroller to .autoscroller in global.css [Checkin: comment 8]

http://hg.mozilla.org/comm-central/rev/07eaa92684b8