482480 - Text on provided identity information seems contradicting

Status: VERIFIED FIXED

(Firefox :: Page Info Window, defect)

Description

[Kadir Topal [:atopal]]

Attachment: screenshot to make the bug report clear

If you click on more information in the site ID dialog, on a website which provides a plain certificate, the page info dialog says that the "Web site does not supply identity information. But two lines below it says: "The web site provides a certificate to verify its identity."

Even I was confused by this.

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Hrm, I believe that there's another bug about making deeper changes here, but we should really change that string so that it's not referring to "identity" information but instead "verified identity" or better yet "ownership and operation" information.

It only shows the EV OU/dba field, right?

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

--> 3.1, as we're not going to take a string change on the 3.0.x branch.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: fixing things by removing things

My first pass was to switch the "Owner:" column to say that the website didn't provide owner information, but we're using "Identity" to mean "verified identity of ownership" throughout the UI so that felt like a half-measure.

The easiest fix is to remove the bit which declares that the certificate is "identity information". Because of that, poking johnath for a ui-review.

I can easily work up the other fix, too.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

(In reply to comment #3)
> The easiest fix is to remove the bit which declares that the certificate is
> "identity information". Because of that, poking johnath for a ui-review.

by "bit" I mean "string" -- now the "View Certificate" button appears if there's a certificate, doesn't if there isn't. The string saying "This website provides a certificate to verify its identity" has been removed.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: certificate present, yet no string

Just so you don't have to apply the patch yourself.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: removing things, s/identity/ownership

Gavin felt that having

Owner: This site does not provide any identity information

still felt awkward. He argued that we've been using "identity" to refer to the whole kit and kaboodle: domain name, and verified identity information. Ownership is an important part of identity, but a component of it.

This patch
 - does everything the old patch does
 - changes the string to say "This site does not provide any ownership information"

We are probably overthinking things, but I present them both for your review and approval! My feeling is that either works fine, it's really a matter of how we want to talk about these metaphors across the product, which requires some input from Johnath.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: screenshot with second patch (security tab)

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: screenshot with second patch (general tab)

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 366722 [details] [diff] [review]
removing things, s/identity/ownership

I like it. Works in both places it's used (General tab and under "Web Site Identity" on the Security tab), I think.

Comment 10

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 366685 [details] [diff] [review]
fixing things by removing things

This is OK too, at least insofar as it won't cause the destruction of Firefox and all who love it, but I don't think it's an ideal fix.

Comment 11

[Johnathan Nightingale [:johnath]]

Comment on attachment 366722 [details] [diff] [review]
removing things, s/identity/ownership

Discussed with beltzner and gavin - I think it makes sense to tie the right side text to the left-side heading ("Owner")

Comment 12

[Johnathan Nightingale [:johnath]]

Comment on attachment 366685 [details] [diff] [review]
fixing things by removing things

The other one is more betterer, clearing the ui-r flag here.

Comment 13

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/964586e5dbad

Comment 14

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 366722 [details] [diff] [review]
removing things, s/identity/ownership

a191=beltzner

Comment 15

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/b98f18be6940

Comment 16

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090507 Minefield/3.6a1pre ID:20090507032833

and

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b5pre) Gecko/20090507 Shiretoko/3.5b5pre ID:20090507034334