Closed Bug 482604 Opened 15 years ago Closed 15 years ago

MemoryProfiler missing some frees

Categories

(Tamarin Graveyard :: Garbage Collection (mmGC), defect)

Product:
Tamarin Graveyard
Component:
Garbage Collection (mmGC)
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: tierney, Unassigned)

Details

Attachments

(1 file)

Switch GCLargeAlloc::Finalize to call FinalizeHook rather than FreeHook
478 bytes, patch
treilly
: review+
Details | Diff | Splinter Review 
MemoryProfiler was reporting much higher numbers for stack traces than it reported for total memory used.  Turns out we were missing a call to FinalizeHook in GCLargeAlloc::Finalize.  It was calling FreeHook, but that doesn't decrement the size/count for the stack trace.
Attachment #366661 - Flags: review?(treilly)
Attachment #366661 - Flags: review?(treilly) → review+
Pushed:  http://hg.mozilla.org/tamarin-redux/rev/36c6de82dce4
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Resolved fixed engineering / work item that has been pushed.  Setting status to verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: