482649 - Sendchange for hg relauto triggers branch builds

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Nick Thomas [:nthomas] (UTC+12)]

The --branch=releases/mozilla-1.9.1 part of doing a sendchange to start the automation also triggers all the build/unit/leak builders (it matches their branch). We don't see this in staging because you have to use users/stage-ffxbld/mozilla-1.9.1 there to act on the dummy repo.

IIRC we use the branch for the Mercurial() operation in ReleaseBuildFactory (via MercurialBuildFactory), which is shared with the dep builds. Perhaps isHgPollerTriggered (or an analogue for sendchange) can help here.

Comment 1

[[e-mail] (:bhearsum)]

Nick, I'm having trouble reproducing this behaviour with a test Buildbot...are you sure there weren't changes being landed around the same time? (I hope not!). I'm going to try and dig up older logs in meantime...

Comment 2

[[e-mail] (:bhearsum)]

I found the problem, patch incoming.

Comment 3

[[e-mail] (:bhearsum)]

Attachment: fix MozScheduler to pass along arguments properly

Looks like MozScheduler passes fileIsImportant=None and properties={} down to Scheduler, instead of passing the arguments it was passed. This patch fixes that.

Comment 4

[Chris AtLee [:catlee]]

Comment on attachment 366904 [details] [diff] [review]
fix MozScheduler to pass along arguments properly

doh, can't believe I wrote that code.

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 366904 [details] [diff] [review]
fix MozScheduler to pass along arguments properly

changeset:   214:efb85303e890

Comment 6

[[e-mail] (:bhearsum)]

buildbot master has been reconfig'ed for this.