482878 - service (_remoteSetup) needs to migrate payload formats

Status: RESOLVED FIXED

(Cloud Services :: General, defect, P1)

Description

[Dan Mills [:thunder]]

We now wrap payloads in an array, and _remoteSetup doesn't deal with that case.  It needs to.

Comment 1

[Ed Lee :Mardak]

Attachment: v1

XX comment because we shouldn't need this down the line.

Comment 2

[Ed Lee :Mardak]

P1 as bug 478327 breaks existing profiles and prevents them from syncing.

Comment 3

[Dan Mills [:thunder]]

Comment on attachment 366975 [details] [diff] [review]
v1

looks great

Comment 4

[Ed Lee :Mardak]

http://hg.mozilla.org/labs/weave/rev/430ce13b63f3

Comment 5

[Ed Lee :Mardak]

Erm. We might need to do something similar again now that I pushed a fix for bug 482670. But then I realized, there won't be a problem if we just bump up the version as it causes a server wipe. Might as well get rid of this now-old migration code.

Comment 6

[Ed Lee :Mardak]

Backed out changeset 430ce13b63f3 (bug 482878)
http://hg.mozilla.org/labs/weave/rev/1edebdd5553f

Bug 482670 restored un-wrapped payloads, so until a version bump, those using trunk will need to do a manual server wipe.

Comment 7

[Dan Mills [:thunder]]

>-    // XXX Bug 482878 Old payloads weren't array-wrapped, so migrate by wiping
>-    if (meta && meta.payload == null) {
>-      this._log.debug("Migrating to minimal payloads by wiping the server");
>-      meta = null;
>-    }
> 
>     let remoteVersion = (meta && meta.payload.storageVersion)?
>       meta.payload.storageVersion : "";

The problem was that even if you bumped the payload, existing old meta records would fail with 'meta.payload is undefined', and execution would stop rather than causing a wipe.

However, by now we've done a lot of version upgrades, and pretty much everyone should be using a version where meta.payload is defined.  So we can leave the extra check out.

Comment 8

[Dan Mills [:thunder]]

> The problem was that even if you bumped the payload, existing old meta records

...even if you bumped the *version*...