482961 - a bad SOLO_FILE should produce an useful error

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, defect)

Description

[Marco Bonardo [:mak]]

Today i was trying to execute a single test using SOLO_FILE, i generate it through a script that was wrongly adding a leading /.
This always worked, while it is not anymore now, removing the leading / has solved the problem, but no useful error was printed out for having a bad SOLO_FILE.

output was:

make: Entering directory `/c/obj-i686-pc-mingw32/browser/toolkit/components/places/tests'
c:/mozilla-build/python25/python.exe \
          /C/mozilla/testing/xpcshell/runxpcshelltests.py \
          --test=/unit/test_history_sidebar.js \
          ../../../../dist/bin/xpcshell \
          /C/mozilla \
          ../../../../_tests/xpcshell/test_places/autocomplete ../../../../_tests/xpcshell/test_places/sync ../../../../_tests/xpcshell/test_places/bookmarks ../../../../_tests/xpcshell/test_places/queries ../../../../_tests/xpcshell/test_places/unit
make: Leaving directory `/c/obj-i686-pc-mingw32/browser/toolkit/components/places/tests'

Comment 1

[(not currently active) Ted Mielczarek]

Serge: did you fix this in another bug somewhere? (I think you did.)

Comment 2

[Serge Gautherie (:sgautherie)]

make SOLO_FILE=test_history_sidebar.js -C objdir/toolkit/components/places/tests check-one
make SOLO_FILE=unit/test_history_sidebar.js -C objdir/toolkit/components/places/tests check-one
{
TEST-PASS | [...]/test_history_sidebar.js | test passed
+
INFO | Passed: 1
}

make SOLO_FILE=/unit/test_history_sidebar.js -C objdir/toolkit/components/places/tests check-one
{
TEST-UNEXPECTED-FAIL | runxpcshelltests.py | No tests run. Did you pass an invalid --test-path?
+
INFO | Failed: 1
}