483403 - Temporarily disable tabstrip smooth scrolling when restoring a window

Status: RESOLVED FIXED

(Firefox :: Session Restore, enhancement)

Description

[Dão Gottwald [:dao]]

Attachment: patch

When a window is being restored, smooth scrolling in the tabstrip should be disabled, because a) it's actually not smooth and b) it's better to immediately get to the state in which the window was closed, i.e. with the selected tab visible.

Comment 1

[Dietrich Ayala (:dietrich)]

Comment on attachment 367380 [details] [diff] [review]
patch

this idea seems ok to me, please get additional review from Simon though. nit: only set smoothScroll if changed from original value?

Comment 2

[Dão Gottwald [:dao]]

(In reply to comment #1)
> only set smoothScroll if changed from original value?

This seems like an unnecessary complication, e.g. I'd need another variable, or make the smoothScroll variable tri-state, or something like that.

Comment 3

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/4b2a90a7726e

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 367380 [details] [diff] [review]
patch

a=191, but if you could see if you can add a quick test for this (perhaps in some of the other session restore tests?) that would be super awesome.

Comment 5

[Dão Gottwald [:dao]]

The test this should probably be added to, the one for bug 480148, is currently disabled...

Comment 6

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/ea29bdab7238