483426 - [10.4] Bookmark bar always has background window (pinstriped) appearance

Status: RESOLVED FIXED

(Camino Graveyard :: Toolbars & Menus, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

There have been a few random complaints about this on the forum, but none of the people ever followed through.  However, hendy noticed this when he last pulled out his G3 iBook for testing and made the sample page in the URL field.  You can see from his screenshot that 2.0* active windows have the inactive-style (pinstriped) bookmark bar instead of the former gradient bar.

The last two checkins that touched this code are bug 401340 and bug 417948, but both of them cross-landed, so that makes them unlikely.  hendy was investigating, and as of last night, his working theory was maybe the differences in - (BOOL)hasUnifiedToolbarAppearance in BrowserWindow between branch and trunk could be the problem (those were introduced by bug 425519 on the trunk):
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/camino/src/browser/BrowserWindow.mm&rev=1.38&mark=199#199
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/camino/src/browser/BrowserWindow.mm&rev=1.12.2.21&mark=197#197

Comment 1

[Christopher Henderson]

31/3/2008 has the gradient, 1/4/2008 doesn't. The only relevent checkin between
those dates is indeed Bug 425519.

Comment 2

[Christopher Henderson]

Attachment: Fix v1.0

Looks like the and statement wasn't being correctly converted to a BOOL, as |hasUnifiedToolbarAppearance| was always returning NO. I tried a cast, but that didn't work either. This ternary statement fixes it up, though.

Comment 3

[Stuart Morgan]

Comment on attachment 367528 [details] [diff] [review]
Fix v1.0

Sigh; I should have noticed that was wrong at the time I made the change.

r/sr=smorgan.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on cvs trunk.