48356 - "Application error" window appears when CurrentPage.findInPage(...) is invoked without URL

Status: VERIFIED FIXED

(Core Graveyard :: Java APIs to WebShell, defect, P3)

Description

[Oleg Khokhlov]

If no URL is loaded and CurrentPage.findInPage(...) is invoked, then 
"Application error" window appears:

   The exception Breakpoint.
   A breakpoint has been reached.
   (0x80000003) occurred in the aplication at location 0x77f76274.

How to reproduce:
1. Start webclient without any URL.
2. Choose the menu item "Search->Find".
3. In the find dialog window type something in "Find" field.
4. Press the "Find" button.


Mozilla M16, Webclient source from Aug 07, 2000. WinNT 4.0 SP4. JDK 1.3.0R.

Comment 1

[Gervase Markham [:gerv]]

Confirming again. [e-mail] - I've fixed your Bugzilla permissions so you 
submit NEW bugs by default.

Gerv

Comment 2

[edburns]

Reassign to Ashu.

Comment 3

[Ashu Kulkarni]

Attachment: cvs diff for src_moz/CurrentPageImpl.cpp

Comment 4

[Ashu Kulkarni]

Attachment: cvs diff -u for CurrentPageImpl.cpp

Comment 5

[Ashu Kulkarni]

Added patch to fix bug. Checked in fix.
Oleg, pls get this fix and run the new code thro your QA tests. thanks.

_Ashu

Comment 6

[Oleg Khokhlov]

"Application error" window still appears:

It appears when interfaceRequestor->GetInterface(NS_GET_IID(nsIDOMWindow), 
getter_AddRefs(domWindow)) is called.

May be we need some check before interfaceRequestor->GetInterface(...) is 
called. Something like that:

nsIURI* url;
rv=initContext->docShell->GetCurrentURI(&url);
 if (NS_FAILED(rv) || nsnull == url)  {
      ::util_ThrowExceptionToJava(env, "Exception: NULL URL passed to Find 
call");
      return;
 } 

I tested findInPage(..) method with this code and it works. But, may be, there 
are other ways exist.

Comment 7

[Ashu Kulkarni]

The patch suggested by Oleg looks good. I'll check it in and confirm that it
works fine before closing this bug.

thanks
_Ashu

Comment 8

[Ashu Kulkarni]

Attachment: Proposed patch - suggested by Oleg - diff -u CurrentPageImpl.cpp

Comment 9

[Ashu Kulkarni]

Attachment: tar.gz of modified patch files

Comment 10

[Ashu Kulkarni]

Attachment: tar.gz of modified patch files

Comment 11

[Ashu Kulkarni]

Attachment: tar.gz of modified patch files

Comment 12

[Ashu Kulkarni]

tar.gz attached multiple times by mistake due to slow responding bugzilla
server.

_Ashu

Comment 13

[edburns]

Comments on http://bugzilla.mozilla.org/showattachment.cgi?attach_id=14422 : 

Use nsCOMPtr<nsIURI> and getter_AddRefs().  If you do that, then I give you 
r=,a= edburns.

Comment 14

[Ashu Kulkarni]

Attachment: diff -u CurrentPageImpl.cpp - Proposed patch

Comment 15

[Ashu Kulkarni]

Attachment: Proposed patch - diff -u CurrentPageImpl.cpp

Comment 16

[Ashu Kulkarni]

Patch checked into cvs. Pls see 09/12/00 09:32 for diff -u of proposed patch and 
09/12/00 09:31 for modified CurrentPageImpl.cpp file

_Ashu

Comment 17

[Keyser Sose]

Works for Me
Platform: PC
OS: Windows 98
Mozilla Version: 2000100508

Marking as Verified