Closed
Bug 483570
Opened 15 years ago
Closed 15 years ago
UMR in nsAsyncEventRunner::Run, LoadNextSource::Run, and SelectResourceEvent::Run
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: kinetik, Assigned: kinetik)
Details
(Keywords: fixed1.9.1, valgrind)
Attachments
(1 file)
|
2.17 KB,
patch
|
roc
:
review+
roc
:
superreview+
roc
:
approval1.9.1+
|
Details | Diff | Splinter Review |
nsHTMLMediaElement does not initialize mCurrentLoadID. This results in UMR warnings in the Run member function of nsAsyncEventRunner, LoadNextSource, and SelectResourceEvent.
|
Assignee | |
Comment 1•15 years ago
|
||
Trivial fix. Also clean up the order of initialization and initialize
Assignee: nobody → kinetik
Attachment #367555 -
Flags: superreview?(roc)
Attachment #367555 -
Flags: review?(roc)
|
|
Assignee | |
Comment 2•15 years ago
|
||
...initialize mPausedBeforeFreeze as well.
Attachment #367555 -
Flags: superreview?(roc)
Attachment #367555 -
Flags: superreview+
Attachment #367555 -
Flags: review?(roc)
Attachment #367555 -
Flags: review+
|
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [needs landing]
http://hg.mozilla.org/mozilla-central/rev/c93612f649ab
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [needs landing] → [needs 191 landing]
Attachment #367555 -
Flags: approval1.9.1+
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/3970d56aac0b
Keywords: fixed1.9.1
Whiteboard: [needs 191 landing]
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b2pre) Gecko/20081106 Firefox/3.1b2pre
Multiple crashs during the Gobal 500 Topsite Run on Top Sites like baidu.com, ebay.com, www.megarotic.com, mail.ru etc). I request blocking 1.9.1 because this seems to be a new regression and affects topsites !
Before the Crashs i see in the Logfiles:
Assertion failure: JSVAL_IS_NULL(vp[0]) || (!JSVAL_IS_PRIMITIVE(vp[0]) && OBJ_IS_ARRAY(cx, JSVAL_TO_OBJECT(vp[0]))), at /work/mozilla/builds/1.9.1-trace-malloc/mozilla/js/src/jsstr.cpp:1448
https://swaghalloween.com/: EXIT STATUS: CRASHED signal 5 SIGTRAP (181.386045 seconds)
Flags: needinfo?(kinetik)
|
|
Assignee | |
Updated•2 years ago
|
Flags: needinfo?(kinetik)
You need to log in
before you can comment on or make changes to this bug.
Description
•