Closed
Bug 483693
Opened 15 years ago
Closed 15 years ago
import from legacy storage should use a transaction for better performance.
Categories
(Toolkit :: Password Manager, defect)
Toolkit
Password Manager
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: Dolske, Assigned: Dolske)
Details
(Keywords: fixed1.9.1)
Attachments
(1 file)
|
1.17 KB,
patch
|
sdwilsh
:
review+
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
After storage-mozStorage.js calls getAllEncryptedLogins() to get data from the legacy storage module, it calls addLogin() / setLoginSavingEnabled() for each item. If there are a lot of items, this can be a bit slow, and wrapping in a transaction helps. On my laptop, the import of signons-08.txt (from the pwmgr unit tests, which has 500 logins and 500 disabled hosts) takes 5.0 seconds with the current code, and 2.1 seconds with this patch.
Attachment #367676 -
Flags: review?(sdwilsh)
|
||
Updated•15 years ago
|
Attachment #367676 -
Flags: review?(sdwilsh) → review+
|
|
||
Comment 1•15 years ago
|
||
Comment on attachment 367676 [details] [diff] [review] Patch v.1 r=sdwilsh
|
||
Comment 2•15 years ago
|
||
Comment on attachment 367676 [details] [diff] [review] Patch v.1 a191=beltzner
Attachment #367676 -
Flags: approval1.9.1+
|
Assignee | |
Comment 3•15 years ago
|
||
Pushed http://hg.mozilla.org/mozilla-central/rev/6ed2d1cbc338
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 4•15 years ago
|
||
Pushed to 191: http://hg.mozilla.org/releases/mozilla-1.9.1/rev/c2ddaf111a3e
Keywords: fixed1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•