484127 - Move browser_scope.js into browser/

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

browser_scope.js tests to make sure the current JS scope is in browser.js, but it is really Firefox specific. Other apps will have different testing scopes. Fennec, for example, uses a browser.js scope, but a different one than Firefox. The Firefox tests actually fail when run in Fennec.

So we will move the current browser_scope.js to browser/ and make a slightly different browser_scope.js for Fennec.

Not sure if Seamonkey needs this or not.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This moves browser_scope.js into browser/base/content/test

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 368186 [details] [diff] [review]
patch

Perhaps we should leave a test in testing/mochitest/tests/browser/ that simply tests for chrome privileges?

Comment 3

[Robert Kaiser]

Actually, the test checks that gBrowser and getBrowser() both work and return the same. I guess a number of extension might depend on one or the other, and SeaMonkey reports success as it provides both in the browser window. But it's probably correct to have the test in browser/ as it's actually very browser-specific things to have that var and that function defined.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch 2 - with a basic privileges test [Checkin: Comment 5 & 6]

same as the previous patch, but this one adds a simple test for script privileges

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 368248 [details] [diff] [review]
patch 2 - with a basic privileges test
[Checkin: Comment 5 & 6]


http://hg.mozilla.org/mozilla-central/rev/9561a35a9e79

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 368248 [details] [diff] [review]
patch 2 - with a basic privileges test
[Checkin: Comment 5 & 6]


http://hg.mozilla.org/releases/mozilla-1.9.1/rev/1b507212507c

Comment 7

[Serge Gautherie (:sgautherie)]

(In reply to comment #6)
> (From update of attachment 368248 [details] [diff] [review])
> 
> http://hg.mozilla.org/releases/mozilla-1.9.1/rev/1b507212507c

Fwiw, this was after fixing context for
{
patching file browser/base/content/test/Makefile.in
Hunk #1 FAILED at 93
1 out of 1 hunks FAILED
}