Closed
Bug 484309
Opened 15 years ago
Closed 15 years ago
xpcom violates xpcom calling conventions
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
People
(Reporter: neil, Assigned: neil)
References
Details
Attachments
(3 files)
|
2.92 KB,
patch
|
benjamin
:
review+
benjamin
:
superreview+
|
Details | Diff | Splinter Review |
|
1.92 KB,
patch
|
benjamin
:
review+
benjamin
:
superreview+
|
Details | Diff | Splinter Review |
|
1.08 KB,
patch
|
benjamin
:
review+
benjamin
:
superreview+
|
Details | Diff | Splinter Review |
nsErrorService (via nsInt2StrHashtable) and nsCategoryManager don't use the XPCOM allocator to allocate return strings, while nsComponentManager doesn't use the XPCOM deallocator to free strings returned from XPCOM methods.
|
Assignee | |
Comment 1•15 years ago
|
||
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #368403 -
Flags: superreview?(benjamin)
Attachment #368403 -
Flags: review?(benjamin)
|
||
Updated•15 years ago
|
Attachment #368403 -
Flags: superreview?(benjamin)
Attachment #368403 -
Flags: superreview+
Attachment #368403 -
Flags: review?(benjamin)
Attachment #368403 -
Flags: review+
|
|
Assignee | |
Comment 2•15 years ago
|
||
Pushed changeset 6be239399910 to mozilla-central.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 4•15 years ago
|
||
Attachment #369929 -
Flags: superreview?(benjamin)
Attachment #369929 -
Flags: review?(benjamin)
|
|
||
Updated•15 years ago
|
Attachment #369929 -
Flags: superreview?(benjamin)
Attachment #369929 -
Flags: superreview+
Attachment #369929 -
Flags: review?(benjamin)
Attachment #369929 -
Flags: review+
|
|
Assignee | |
Comment 5•15 years ago
|
||
Comment on attachment 369929 [details] [diff] [review] Overlooked some _Frees Pushed changeset bd377cffab2c to mozilla-central.
|
|
Assignee | |
Comment 6•15 years ago
|
||
Sorry, but my detection is only as good as my code coverage, so as I increase coverage (in this case by running xpcshell tests) I get more detections...
Attachment #371249 -
Flags: superreview?(benjamin)
Attachment #371249 -
Flags: review?(benjamin)
|
|
||
Updated•15 years ago
|
Attachment #371249 -
Flags: superreview?(benjamin)
Attachment #371249 -
Flags: superreview+
Attachment #371249 -
Flags: review?(benjamin)
Attachment #371249 -
Flags: review+
|
|
Assignee | |
Comment 7•15 years ago
|
||
Comment on attachment 371249 [details] [diff] [review] Overlooked some more _Frees Pushed changeset 964349d0ad35 to mozilla-central.
You need to log in
before you can comment on or make changes to this bug.
Description
•