Closed
Bug 484310
Opened 15 years ago
Closed 15 years ago
nsCharsetMenu violates XPCOM calling conventions
Categories
(Core :: Internationalization, defect)
Core
Internationalization
Tracking
()
RESOLVED
FIXED
People
(Reporter: neil, Assigned: neil)
Details
Attachments
(1 file)
|
841 bytes,
patch
|
smontagu
:
review+
jag+mozilla
:
superreview+
|
Details | Diff | Splinter Review |
nsCharsetMenu::GetURI calls PL_strdup, but it should use the XPCOM allocator.
|
Assignee | |
Comment 1•15 years ago
|
||
Assignee: smontagu → neil
Status: NEW → ASSIGNED
Attachment #368405 -
Flags: superreview?(jag)
Attachment #368405 -
Flags: review?(smontagu)
|
||
Comment 2•15 years ago
|
||
Comment on attachment 368405 [details] [diff] [review] Proposed patch I would suggest we change nsCRT::strdup(const char*) to use the same allocator as nsCRT::strdup(const PRUnichar*), but that's gonna affect a lot more people. New bug?
Attachment #368405 -
Flags: superreview?(jag) → superreview+
|
||
Comment 3•15 years ago
|
||
Comment on attachment 368405 [details] [diff] [review] Proposed patch If only he was an intl peer, it would have been more appropriate to get Uri to review this...
Attachment #368405 -
Flags: review?(smontagu) → review+
|
|
Assignee | |
Comment 4•15 years ago
|
||
Pushed changeset e1120120b1b7 to mozilla-central.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•