485044 - [ta] Firefox 3.5 RSS reader setup for Tamil

Status: RESOLVED FIXED

(Mozilla Localizations :: ta / Tamil, defect)

Description

[Staś Małolepszy :stas]

RSS readers are web services allowing users to subscribe to RSS feeds online and view them. If Firefox detects a feed, it offers the user to subscribe to it, either as a live bookmark or via one of the web services.

The current RSS Readers in en-US are Bloglines, My Yahoo, Google.

We want to ship a good set of defaults for Tamil, and will work towards that in three stages.

First, the localization team and Stas (Stas Malolepszy) will look at the market for the language and come up with a good candidates. Felix, we'll need your input on this, the guidelines for making recommendations are on http://wiki.mozilla.org/Firefox_web_services_guidelines. After we decided on a particular RSS reader, Stas will contact the owner and ask for permission. undefined, we'll likely need your help to at least get the contact information.

Once we have a specification on what the set of RSS readers for Tamil should look like, the localization team and Stas will work on an implementation on that. This should happen by the localization team creating and attaching patches for the desired changes, and requesting review from Stas. After a successful review, the localization team will land them. If you're not feeling comfortable with creating those changes, ask Stas to help out.

Please don't commit any modifications in l10n/ta/browser/chrome/browser-region/region.properties to the cvs repository without a patch reviewed by Stas, Axel or someone else appointed by Stas/SethB. The data here is sensitive to users and our search partners, thus the extra care here.

Comment 1

[Staś Małolepszy :stas]

In bug 419032 comment 2, Sarves writes:

RSS in Tamil : 
We do have a Tamil blog. And I was able to add the RSS of that blog to Google
reader. And its working correctly.

Comment 2

[Axel Hecht [:Pike]]

http://hg.mozilla.org/releases/l10n-mozilla-1.9.1/ta/diff/5be376add6e0/browser/chrome/browser-region/region.properties landed without review, Stas, can you do that post-mortem?

Comment 3

[Staś Małolepszy :stas]

The landing that Axel mentions in comment 2 is technically OK. 

Felix, Sarves: is the default set of feed readers (Bloglines, My Yahoo, Google) fine for out Tamil users?

Comment 4

[Staś Małolepszy :stas]

Felix, Sarves: ping?

Comment 5

[Felix]

Hi stas, Most of the Tamil reader are using Google reader including me. So we can make google as default and rest of the things also we can have.

Comment 6

[Staś Małolepszy :stas]

I'd say that the current order is fine for now, but I'll be happy to take a patch to change it, if you can create one. Please attach it to this bug for a review.

Comment 7

[Seth Bindernagel]

Attachment: Proposed [ta] patch shifting the order of RSS Readers

Hoping to help the Tamil team with its request to shift the order of RSS readers, I created this patch that reorders the list of readers for the Tamil version.  The new order places Google Reader first, Bloglines second, and Yahoo! third.

Comment 8

[Staś Małolepszy :stas]

Comment on attachment 383788 [details] [diff] [review]
Proposed [ta] patch shifting the order of RSS Readers

Awesome, thanks Seth!

r=me. Felix, please land this patch on branch (1.9.1) and trunk (l10n-central) using a descriptive check-in comment, mentioning the bug number and my review (e.g. "Bug 485044: Feed reader setup, change order to Google, Bloglines, My Yahoo!, p=sethb, r=stas").

Please use fixed1.9.1 and verified1.9.1 keywords in this bug to track landing and verification on the 1.9.1 branch.

Comment 9

[Felix]

Hi Stats, Seth,

Thanks for working on creating the patch and reviewing it, but to me the patch looks entirely different compared to current file: http://hg.mozilla.org/releases/l10n-mozilla-1.9.1/ta/file/5be376add6e0/browser/chrome/browser-region/region.properties

Stats, I think it would be better if you could review the patch against the actual file again and do the submission on behalf of me, if you find it's okay.

Comment 10

[Staś Małolepszy :stas]

Felix: I'm not sure if I understand. Have you tried to apply the patch using |patch -p1 < path/to/patch.diff| in your local hg clone?

Comment 11

[Felix]

Hi stas,

I am getting the following error:
[ifelix@ifelix ta]$ patch -p1 < /home/ifelix/Desktop/ta_diff 
patching file browser/chrome/browser-region/region.properties
Hunk #1 FAILED at 2.
1 out of 1 hunk FAILED -- saving rejects to file browser/chrome/browser-region/region.properties.rej

Comment 12

[Staś Małolepszy :stas]

Comment on attachment 383788 [details] [diff] [review]
Proposed [ta] patch shifting the order of RSS Readers

Hi Felix,

Thanks for letting me know. As you said, it looks like the patch was created against an older revision of the file, which didn't include the localization note in lines 1 to 5. Sorry for that.

The patch specified the lines to look up in the file as follows:
>@@ -2,17 +2,18 @@
whereas it should have started from line 7, not 2.

An easy fix is to apply the patch with a fuzz factor 5, which means that we're asking to look for the changed lines 5 lines before and 5 lines after the specified line 2. Thus,

patch -p1 -F5 < ~/Desktop/ta_diff 

should do the trick. 

Felix, if you still prefer that I land this patch for you, please let me know. I'll be happy to do it.

Comment 13

[Felix]

Hi stas,

Again I am getting this following error:

[ifelix@ifelix ta]$ patch -p1 -F5 < ~/Desktop/ta_diffpatching file browser/chrome/browser-region/region.properties
Hunk #1 succeeded at 7 with fuzz 5 (offset 5 lines).
[ifelix@ifelix ta]$ hg commit -m "Bug 485044: Feed reader setup, change order to Google, Bloglines, My Yahoo, p=sethb, r=stas"
created new head
[ifelix@ifelix ta]$ hg push
pushing to http://hg.mozilla.org/releases/l10n-mozilla-1.9.1/ta
searching for changes
abort: push creates new remote heads!
(did you forget to merge? use push -f to force)
[ifelix@ifelix ta]$ hg push -f
pushing to http://hg.mozilla.org/releases/l10n-mozilla-1.9.1/ta
searching for changes
ssl required

So possible pls land this patch for me.

Comment 14

[Staś Małolepszy :stas]

(In reply to comment #13)
> [ifelix@ifelix ta]$ hg push -f
> pushing to http://hg.mozilla.org/releases/l10n-mozilla-1.9.1/ta
> searching for changes
> ssl required
> 
> So possible pls land this patch for me.

Not that I don't want to land this for you, but you're almost there and i think it will make it easier for you to land in the future. The reason why you're getting this error is that your pushing to http://..., instead of ssh://. Please edit your ta/.hg/hgrc file and make sure default-push is defined like this:
default-push = ssh://hg.mozilla.org/releases/l10n-mozilla-1.9.1/ta

However, I just learned that we're having some problems with the LDAP authentication right now, so you'll probably won't be able to push immediately. Neither will I, fwiw. Bug 499288 tracks this issue.

Comment 15

[Staś Małolepszy :stas]

Felix, have you managed to apply and commit the patch? Happy to help with the landing, just let me know.

Comment 16

[Staś Małolepszy :stas]

Landed on 1.9.1: http://hg.mozilla.org/releases/l10n-mozilla-1.9.1/ta/rev/3b94e4cf6bc0

I tested in a nightly build and it looked fine. So, I submitted a new opt-in revision to Axel in the opt-in thread.

We'll close this bug when we migrate [ta] to 1.9.2 and central (from 1.9.1). Leaving it open until then.

Comment 17

[Axel Hecht [:Pike]]

Stas, AFAICT you didn't update l10n-src-verification on this one?

I see the same region.properties in 1.9.2 and in 1.9.1, fwiw.

Comment 18

[Staś Małolepszy :stas]

updated now: http://hg.mozilla.org/l10n/l10n-src-verification/rev/65f07320b8fc

what you saw was OK :)

Comment 19

[Axel Hecht [:Pike]]

http://hg.mozilla.org/l10n-central/ta/rev/3b94e4cf6bc0, FIXED.